diff options
| author | Ted Mielczarek <ted@mielczarek.org> | 2016-06-10 13:23:29 -0400 |
|---|---|---|
| committer | Ted Mielczarek <ted@mielczarek.org> | 2016-06-10 13:23:29 -0400 |
| commit | c44217f6468152bf5693df7ec78a48d97e2b0e83 (patch) | |
| tree | f05595f7a39b34c8111c6a74bfbf505c66dfa4b1 /src/common/linux/dump_symbols.cc | |
| parent | Fix a trivial parsing bug caught by static analysis (diff) | |
| download | breakpad-c44217f6468152bf5693df7ec78a48d97e2b0e83.tar.xz | |
Dump INFO CODE_ID containing Build ID in Linux dump_syms
I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.
Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.
R=mark@chromium.org
BUG=
Review URL: https://codereview.chromium.org/2052263002 .
Diffstat (limited to 'src/common/linux/dump_symbols.cc')
| -rw-r--r-- | src/common/linux/dump_symbols.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/common/linux/dump_symbols.cc b/src/common/linux/dump_symbols.cc index 6b27120a..40b9e478 100644 --- a/src/common/linux/dump_symbols.cc +++ b/src/common/linux/dump_symbols.cc @@ -926,8 +926,10 @@ bool InitModuleForElfClass(const typename ElfClass::Ehdr* elf_header, // number appended to the end of the file identifier; this isn't // really used or necessary on other platforms, but be consistent. string id = FileID::ConvertIdentifierToUUIDString(identifier) + "0"; + // This is just the raw Build ID in hex. + string code_id = FileID::ConvertIdentifierToString(identifier); - module.reset(new Module(name, os, architecture, id)); + module.reset(new Module(name, os, architecture, id, code_id)); return true; } |