diff options
author | benchan@chromium.org <benchan@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-01-19 07:14:51 +0000 |
---|---|---|
committer | benchan@chromium.org <benchan@chromium.org@4c0a9323-5329-0410-9bdc-e9ce6186880e> | 2012-01-19 07:14:51 +0000 |
commit | 30566abed8d95b752f31f67fde94c0ae0a1502d2 (patch) | |
tree | 90f98f074cebf21102ad8f8717a2e70e9f4438a9 /src/common/linux/elf_core_dump_unittest.cc | |
parent | Skip ElfCoreDumpTest.ValidCoreFile test if no core dump is generated. (diff) | |
download | breakpad-30566abed8d95b752f31f67fde94c0ae0a1502d2.tar.xz |
Implement core dump to minidump conversion.
This patch is part of a bigger patch that helps merging the breakpad code
with the modified version in Chromium OS.
Specifically, this patch makes the following changes:
1. Turn the LinuxDumper class into a base class and move ptrace related
code into a new derived class, LinuxPtraceDumper.
2. Add a LinuxCoreDumper class, which is derived from LinuxDumper, to
extract information from a crashed process via a core dump file instead
of ptrace.
3. Add a WriteMinidumpFromCore function to
src/client/linux/minidump_writer/minidump_writer.h,
which uses LinuxCoreDumper to extract information from a core dump file.
4. Add a core2md utility, which simply wraps WriteMinidumpFromCore, for
converting a core dump to a minidump.
BUG=455
TEST=Tested the following:
1. Build on 32-bit and 64-bit Linux with gcc 4.4.3 and gcc 4.6.
2. Build on Mac OS X 10.6.8 with gcc 4.2 and clang 3.0 (with latest gmock).
3. All unit tests pass.
4. Run Chromium OS tests to test core2md.
Review URL: http://breakpad.appspot.com/343001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@905 4c0a9323-5329-0410-9bdc-e9ce6186880e
Diffstat (limited to 'src/common/linux/elf_core_dump_unittest.cc')
-rw-r--r-- | src/common/linux/elf_core_dump_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/linux/elf_core_dump_unittest.cc b/src/common/linux/elf_core_dump_unittest.cc index 89496ab9..11920f25 100644 --- a/src/common/linux/elf_core_dump_unittest.cc +++ b/src/common/linux/elf_core_dump_unittest.cc @@ -141,7 +141,7 @@ TEST(ElfCoreDumpTest, ValidCoreFile) { // TODO(benchan): Revert to use ASSERT_TRUE once the flakiness in // CrashGenerator is identified and fixed. if (!crash_generator.CreateChildCrash(kNumOfThreads, kCrashThread, - kCrashSignal)) { + kCrashSignal, NULL)) { fprintf(stderr, "ElfCoreDumpTest.ValidCoreFile test is skipped " "due to no core dump generated"); return; |