From 258f2459fcd0621bb84f50833c8348e08ec6fa4f Mon Sep 17 00:00:00 2001 From: "ted.mielczarek" Date: Wed, 25 Apr 2012 11:21:45 +0000 Subject: Reap child in VerifyStackReadWithMultipleThreads Patch by Chris Dearman R=benchan at http://breakpad.appspot.com/378001 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@956 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index 5f7995c1..a1665082 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -252,7 +252,14 @@ TEST(LinuxPtraceDumperTest, VerifyStackReadWithMultipleThreads) { 4); EXPECT_EQ(dumper.threads()[i], one_thread_id); } + EXPECT_TRUE(dumper.ThreadsResume()); kill(child_pid, SIGKILL); + + // Reap child + int status; + ASSERT_NE(-1, HANDLE_EINTR(waitpid(child_pid, &status, 0))); + ASSERT_TRUE(WIFSIGNALED(status)); + ASSERT_EQ(SIGKILL, WTERMSIG(status)); } TEST(LinuxPtraceDumperTest, BuildProcPath) { -- cgit v1.2.1