From 52b33b2a4b9f374255817afecc6e7d215fa80f28 Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Fri, 6 Mar 2020 10:40:39 -0500 Subject: dump_syms: Reintroduce warnings inadvertently removed by 47cd498384fd Previously, dump_syms produced warnings whenever a DW_AT_specification or DW_AT_abstract_origin attribute was a forward reference. 47cd498384fd allowed those attributes to carry forward references, removing the warnings altogether. It was not correct to remove the warnings entirely. References that do not point to valid DIEs should still produce warnings, whether a back reference or a forward reference. This reintroduces those warnings as appropriate. Bug: google-breakpad:813 Test: dumper_unittest SimpleCU.UnknownAbstractOrigin,Specifications.BadOffset Change-Id: Ie7222c7a1886bab31423f27e2fbcce93e69625b3 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2090103 Reviewed-by: Mike Frysinger --- default.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'default.xml') diff --git a/default.xml b/default.xml index ec1cd045..8e8c6cd5 100644 --- a/default.xml +++ b/default.xml @@ -32,7 +32,7 @@