From 0d53bdd43d36d9ff64715b9caa01d49b4649da77 Mon Sep 17 00:00:00 2001 From: Primiano Tucci Date: Mon, 28 Sep 2015 13:52:54 +0100 Subject: Add GPU fingerprint information to breakpad microdumps. Although strictly the GPU fingerprint is defined by the build fingerprint, there is not currently a straightforward mapping from build fingerprint to useful GPU / GL driver information. In order to aid debugging of WebView crashes that occur in GL drivers, and to better understand the range of drivers and versions for feature blacklisting purposes, it is useful to have GPU fingerprints in breakpad microdumps. Landing this patch on behalf of Tobias Sargeant BUG=chromium:536769 R=primiano@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1334473003 . --- src/client/linux/handler/exception_handler.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/client/linux/handler/exception_handler.cc') diff --git a/src/client/linux/handler/exception_handler.cc b/src/client/linux/handler/exception_handler.cc index 5bd2d8cc..148d61f9 100644 --- a/src/client/linux/handler/exception_handler.cc +++ b/src/client/linux/handler/exception_handler.cc @@ -592,8 +592,7 @@ bool ExceptionHandler::DoDump(pid_t crashing_process, const void* context, context, context_size, mapping_list_, - minidump_descriptor_.microdump_build_fingerprint(), - minidump_descriptor_.microdump_product_info()); + *minidump_descriptor_.microdump_extra_info()); } if (minidump_descriptor_.IsFD()) { return google_breakpad::WriteMinidump(minidump_descriptor_.fd(), -- cgit v1.2.1