From 0d53bdd43d36d9ff64715b9caa01d49b4649da77 Mon Sep 17 00:00:00 2001 From: Primiano Tucci Date: Mon, 28 Sep 2015 13:52:54 +0100 Subject: Add GPU fingerprint information to breakpad microdumps. Although strictly the GPU fingerprint is defined by the build fingerprint, there is not currently a straightforward mapping from build fingerprint to useful GPU / GL driver information. In order to aid debugging of WebView crashes that occur in GL drivers, and to better understand the range of drivers and versions for feature blacklisting purposes, it is useful to have GPU fingerprints in breakpad microdumps. Landing this patch on behalf of Tobias Sargeant BUG=chromium:536769 R=primiano@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1334473003 . --- src/client/linux/microdump_writer/microdump_writer.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/client/linux/microdump_writer/microdump_writer.h') diff --git a/src/client/linux/microdump_writer/microdump_writer.h b/src/client/linux/microdump_writer/microdump_writer.h index e2185583..7c742761 100644 --- a/src/client/linux/microdump_writer/microdump_writer.h +++ b/src/client/linux/microdump_writer/microdump_writer.h @@ -37,6 +37,8 @@ namespace google_breakpad { +struct MicrodumpExtraInfo; + // Writes a microdump (a reduced dump containing only the state of the crashing // thread) on the console (logcat on Android). These functions do not malloc nor // use libc functions which may. Thus, it can be used in contexts where the @@ -56,8 +58,7 @@ bool WriteMicrodump(pid_t crashing_process, const void* blob, size_t blob_size, const MappingList& mappings, - const char* build_fingerprint, - const char* product_info); + const MicrodumpExtraInfo& microdump_extra_info); } // namespace google_breakpad -- cgit v1.2.1