From 232c45abee1753785ae32938589eede535bdb06d Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Mon, 8 Apr 2019 20:08:59 -0400 Subject: linux_core_dumper: add missing newline to Android test-disabled message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The [ OK ] LinuxCoreDumperTest.VerifyExceptionDetails line does not appear at the beginning of a line, hiding it from Chromium’s test infrastructure. This causes the test to have an unknown result, which is treated as a failure. https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/233129 Bug: google-breakpad:791 Change-Id: I0eb646a219fa40347db884fd28ace647328c5e49 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1558893 Reviewed-by: Mike Frysinger --- src/client/linux/minidump_writer/linux_core_dumper_unittest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/client/linux/minidump_writer/linux_core_dumper_unittest.cc') diff --git a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc index 314257d9..212b151b 100644 --- a/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc @@ -94,7 +94,7 @@ TEST(LinuxCoreDumperTest, VerifyDumpWithMultipleThreads) { struct stat st; if (stat(core_file.c_str(), &st) != 0) { fprintf(stderr, "LinuxCoreDumperTest.VerifyDumpWithMultipleThreads test is " - "skipped due to no core file being generated"); + "skipped due to no core file being generated\n"); return; } #endif @@ -155,7 +155,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) { struct stat st; if (stat(core_file.c_str(), &st) != 0) { fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " - "skipped due to no core file being generated"); + "skipped due to no core file being generated\n"); return; } #endif @@ -170,7 +170,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) { // TODO: For some reason, Android doesn't seem to pass this. if (!dumper.crash_address()) { fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " - "skipped due to missing signal details on Android"); + "skipped due to missing signal details on Android\n"); return; } #endif -- cgit v1.2.1