From 8785c0cb8fc1ccfb20c143026c5fbb8361354c09 Mon Sep 17 00:00:00 2001 From: "rmcilroy@chromium.org" Date: Fri, 19 Jun 2015 16:30:42 +0000 Subject: Update breakpad for Android packed relocations. Shared libraries containing Android packed relocations have a load bias that differs from the start address in /proc/$$/maps. Current breakpad assumes that the load bias and mapping start address are the same. Fixed by changing the client to detect the presence of Android packed relocations in the address space of a loaded library, and adjusting the stored mapping start address of any that are packed so that it contains the linker's load bias. For this to work properly, it is important that the non-packed library is symbolized for breakpad. Either packed or non-packed libraries may be run on the device; the client detects which has been loaded by the linker. BUG=499747 R=primiano@chromium.org, rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1189823002. Patch from Simon Baldwin . git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1459 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/linux/minidump_writer/minidump_writer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/client/linux/minidump_writer/minidump_writer.cc') diff --git a/src/client/linux/minidump_writer/minidump_writer.cc b/src/client/linux/minidump_writer/minidump_writer.cc index 0414bb72..9c1db99b 100644 --- a/src/client/linux/minidump_writer/minidump_writer.cc +++ b/src/client/linux/minidump_writer/minidump_writer.cc @@ -154,7 +154,7 @@ class MinidumpWriter { else if (!minidump_writer_.Open(path_)) return false; - return dumper_->ThreadsSuspend(); + return dumper_->ThreadsSuspend() && dumper_->LateInit(); } ~MinidumpWriter() { -- cgit v1.2.1