From 8c70c504b241f918e41f28a3102f5ca03475082b Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Fri, 19 Apr 2019 17:08:56 -0400 Subject: Make breakpad_unittests work with Chrome's test runner instead of gtest's Chrome's test runner on Linux installs its own StackDumpSignalHandler which swallows signals and doesn't re-raise them. This is sloppy, but apparently there are reasons (https://crbug.com/551681). For breakpad_unittests, it causes problems where a test process expects (via waitpid()) to observe a child crash. Deal with those cases by explicitly restoring the default signal handler. In another case, Chrome's test runner seems to have been arriving at the conclusion that it was to expect output from a child. Transitioning from exit() to _exit() fixes this problem, and it's not necessarily a bad idea to do this in post-fork() children without an execve() anyway. Bug: chromium:949098 Change-Id: I5a6af0c2a09cd8eac9998358f6d5ea665288236f Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1575670 Reviewed-by: Mark Mentovai --- src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/client/linux/minidump_writer') diff --git a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc index a4a0fd9b..3060327f 100644 --- a/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc +++ b/src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc @@ -144,8 +144,8 @@ class LinuxPtraceDumperChildTest : public testing::Test { if (child_pid_ == 0) { // child process RealTestBody(); - exit(HasFatalFailure() ? kFatalFailure : - (HasNonfatalFailure() ? kNonFatalFailure : 0)); + _exit(HasFatalFailure() ? kFatalFailure : + (HasNonfatalFailure() ? kNonFatalFailure : 0)); } ASSERT_TRUE(child_pid_ > 0); @@ -250,7 +250,7 @@ void LinuxPtraceDumperMappingsTest::SetUp() { helper_path_ = GetHelperBinary(); if (helper_path_.empty()) { FAIL() << "Couldn't find helper binary"; - exit(1); + _exit(1); } // mmap two segments out of the helper binary, one -- cgit v1.2.1