From 5f112cb1743aa832bcb14530bd98cbacf0f49df4 Mon Sep 17 00:00:00 2001 From: Leonard Mosescu Date: Thu, 6 Jul 2017 10:58:40 -0700 Subject: A couple of minor fixes 1. Fixing ExceptionHandlerTest.FirstChanceHandlerRuns: exit() is not an async-signal-safe function (http://man7.org/linux/man-pages/man7/signal-safety.7.html) 2. Fixing entry point signature in minidump_dump Changed "const char* argv[]" to "char* argv[]" to match the standard entry point signature 3. Updating .gitignore to exclude unit test artifacts Change-Id: I9662898d0bd97769621fb6476a720105821c60f0 Reviewed-on: https://chromium-review.googlesource.com/562356 Reviewed-by: Mark Mentovai Reviewed-by: Ivan Penkov Reviewed-by: Joshua Peraza --- src/client/linux/handler/exception_handler_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/client/linux') diff --git a/src/client/linux/handler/exception_handler_unittest.cc b/src/client/linux/handler/exception_handler_unittest.cc index eda60c95..193a76e7 100644 --- a/src/client/linux/handler/exception_handler_unittest.cc +++ b/src/client/linux/handler/exception_handler_unittest.cc @@ -468,7 +468,7 @@ TEST(ExceptionHandlerTest, StackedHandlersUnhandledToBottom) { namespace { const int kSimpleFirstChanceReturnStatus = 42; bool SimpleFirstChanceHandler(int, void*, void*) { - exit(kSimpleFirstChanceReturnStatus); + _exit(kSimpleFirstChanceReturnStatus); } } -- cgit v1.2.1