From b5e5d8bd3074f4decc5e942291db5c004685c48d Mon Sep 17 00:00:00 2001 From: "altse@chromium.org" Date: Thu, 12 Dec 2013 19:58:00 +0000 Subject: Remove usage of gDebugLog and DEBUGLOG from Mac and iOS client code. The inconsistent and duplicated references to gDebugLog caused problems building on iOS and the current logging implementation had little utility because it was never activated in debug builds. git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1257 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/mac/Framework/Breakpad.mm | 18 ------------------ 1 file changed, 18 deletions(-) (limited to 'src/client/mac/Framework') diff --git a/src/client/mac/Framework/Breakpad.mm b/src/client/mac/Framework/Breakpad.mm index 8967be1e..a1336475 100644 --- a/src/client/mac/Framework/Breakpad.mm +++ b/src/client/mac/Framework/Breakpad.mm @@ -28,15 +28,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // -#define VERBOSE 0 -#if VERBOSE - static bool gDebugLog = true; -#else - static bool gDebugLog = false; -#endif - -#define DEBUGLOG if (gDebugLog) fprintf #define IGNORE_DEBUGGER "BREAKPAD_IGNORE_DEBUGGER" #import "client/mac/Framework/Breakpad.h" @@ -311,7 +303,6 @@ NSString * GetResourcePath() { // executable code, since that's how the Breakpad framework is built. resourcePath = [bundlePath stringByAppendingPathComponent:@"Resources/"]; } else { - DEBUGLOG(stderr, "Could not find GetResourcePath\n"); // fallback plan NSBundle *bundle = [NSBundle bundleWithIdentifier:@"com.Google.BreakpadFramework"]; @@ -330,7 +321,6 @@ bool Breakpad::Initialize(NSDictionary *parameters) { // Check for debugger if (IsDebuggerActive()) { - DEBUGLOG(stderr, "Debugger is active: Not installing handler\n"); return true; } @@ -505,7 +495,6 @@ bool Breakpad::ExtractParameters(NSDictionary *parameters) { if (!inspectorPathString || !reporterPathString) { resourcePath = GetResourcePath(); if (!resourcePath) { - DEBUGLOG(stderr, "Could not get resource path\n"); return false; } } @@ -518,7 +507,6 @@ bool Breakpad::ExtractParameters(NSDictionary *parameters) { // Verify that there is an Inspector tool. if (![[NSFileManager defaultManager] fileExistsAtPath:inspectorPathString]) { - DEBUGLOG(stderr, "Cannot find Inspector tool\n"); return false; } @@ -534,7 +522,6 @@ bool Breakpad::ExtractParameters(NSDictionary *parameters) { // Verify that there is a Reporter application. if (![[NSFileManager defaultManager] fileExistsAtPath:reporterPathString]) { - DEBUGLOG(stderr, "Cannot find Reporter tool\n"); return false; } @@ -544,17 +531,14 @@ bool Breakpad::ExtractParameters(NSDictionary *parameters) { // The product, version, and URL are required values. if (![product length]) { - DEBUGLOG(stderr, "Missing required product key.\n"); return false; } if (![version length]) { - DEBUGLOG(stderr, "Missing required version key.\n"); return false; } if (![urlStr length]) { - DEBUGLOG(stderr, "Missing required URL key.\n"); return false; } @@ -651,8 +635,6 @@ bool Breakpad::HandleException(int exception_type, int exception_code, int exception_subcode, mach_port_t crashing_thread) { - DEBUGLOG(stderr, "Breakpad: an exception occurred\n"); - if (filter_callback_) { bool should_handle = filter_callback_(exception_type, exception_code, -- cgit v1.2.1