From 06c856fd6762fc886edd031aad94e6ca4b2064a5 Mon Sep 17 00:00:00 2001 From: "mark@chromium.org" Date: Mon, 28 Nov 2011 19:17:41 +0000 Subject: Speculative back-out of r883, which may have broken Windows crash reporting. git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@891 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/windows/handler/exception_handler.cc | 6 ------ src/client/windows/handler/exception_handler.h | 6 ------ 2 files changed, 12 deletions(-) (limited to 'src/client/windows/handler') diff --git a/src/client/windows/handler/exception_handler.cc b/src/client/windows/handler/exception_handler.cc index fc55ca72..ec5397dc 100644 --- a/src/client/windows/handler/exception_handler.cc +++ b/src/client/windows/handler/exception_handler.cc @@ -704,12 +704,6 @@ bool ExceptionHandler::WriteMinidump(const wstring &dump_path, return handler.WriteMinidump(); } -bool ExceptionHandler::RequestMinidumpForParent() { - if (!IsOutOfProcess()) - return false; - return crash_generation_client_->RequestParentDump(); -} - bool ExceptionHandler::WriteMinidumpWithException( DWORD requesting_thread_id, EXCEPTION_POINTERS* exinfo, diff --git a/src/client/windows/handler/exception_handler.h b/src/client/windows/handler/exception_handler.h index 7b2da3f3..2c2e7b76 100644 --- a/src/client/windows/handler/exception_handler.h +++ b/src/client/windows/handler/exception_handler.h @@ -190,12 +190,6 @@ class ExceptionHandler { static bool WriteMinidump(const wstring &dump_path, MinidumpCallback callback, void* callback_context); - // Requests a minidump of the server be generated and waits for completion. - // This can be used to capture the execution state of parent process - // independent of a crash on either side of the connection. Only valid for - // out-of-process clients. - bool RequestMinidumpForParent(); - // Get the thread ID of the thread requesting the dump (either the exception // thread or any other thread that called WriteMinidump directly). This // may be useful if you want to include additional thread state in your -- cgit v1.2.1