From dbf56c53a039cb91b6f2a7e00b3ac833509f5b92 Mon Sep 17 00:00:00 2001 From: Ted Mielczarek Date: Tue, 6 Oct 2015 08:03:57 -0400 Subject: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. The Windows client gyp files were missing proc_maps_linux.cc for the unittest build. Adding that revealed some build errors due to it unconditionally including . Removing the workarounds in breakpad_types.h (and a few other places) made that build, which means that Visual C++ 2013 is now our minimum supported version of MSVC. Additionally I tried building with VC++ 2015 and fixed a few warnings (which were failing the build because we have /WX enabled) to ensure that that builds as well. BUG=https://code.google.com/p/google-breakpad/issues/detail?id=669 R=mark@chromium.org Review URL: https://codereview.chromium.org/1353893002 . --- src/client/windows/tests/crash_generation_app/crash_generation_app.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/client/windows/tests/crash_generation_app') diff --git a/src/client/windows/tests/crash_generation_app/crash_generation_app.cc b/src/client/windows/tests/crash_generation_app/crash_generation_app.cc index ad395d6c..0d837e52 100644 --- a/src/client/windows/tests/crash_generation_app/crash_generation_app.cc +++ b/src/client/windows/tests/crash_generation_app/crash_generation_app.cc @@ -73,7 +73,7 @@ BOOL InitInstance(HINSTANCE, int); LRESULT CALLBACK WndProc(HWND, UINT, WPARAM, LPARAM); INT_PTR CALLBACK About(HWND, UINT, WPARAM, LPARAM); -static int kCustomInfoCount = 2; +static size_t kCustomInfoCount = 2; static CustomInfoEntry kCustomInfoEntries[] = { CustomInfoEntry(L"prod", L"CrashTestApp"), CustomInfoEntry(L"ver", L"1.0"), -- cgit v1.2.1