From 8b653462422ee6c18af6b99d2b203d7ae2bc5713 Mon Sep 17 00:00:00 2001 From: "cdn@chromium.org" Date: Fri, 17 Jan 2014 22:39:11 +0000 Subject: Refactor the Windows MinidumpGenerator interface to get rid of the overloads when generating dumps. All required params are now passed to the constructor and the various options are set through new methods. BUG=N/A TEST=Existing minidump generation tests R=mark@chromium.org Review URL: https://breakpad.appspot.com/1074002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1274 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/windows/unittests/minidump_test.cc | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) (limited to 'src/client/windows/unittests') diff --git a/src/client/windows/unittests/minidump_test.cc b/src/client/windows/unittests/minidump_test.cc index e3097f28..8d2d726c 100644 --- a/src/client/windows/unittests/minidump_test.cc +++ b/src/client/windows/unittests/minidump_test.cc @@ -104,19 +104,19 @@ class MinidumpTest: public testing::Test { &ctx_record, }; - MinidumpGenerator generator(dump_path_); - + MinidumpGenerator generator(dump_path_, + ::GetCurrentProcess(), + ::GetCurrentProcessId(), + ::GetCurrentThreadId(), + ::GetCurrentThreadId(), + &ex_ptrs, + NULL, + static_cast(flags), + TRUE); + generator.GenerateDumpFile(&dump_file_); + generator.GenerateFullDumpFile(&full_dump_file_); // And write a dump - bool result = generator.WriteMinidump(::GetCurrentProcess(), - ::GetCurrentProcessId(), - ::GetCurrentThreadId(), - ::GetCurrentThreadId(), - &ex_ptrs, - NULL, - static_cast(flags), - TRUE, - &dump_file_, - &full_dump_file_); + bool result = generator.WriteMinidump(); return result == TRUE; } -- cgit v1.2.1