From f33dd18fd26fc4fa3f0f53d29f57fdd894e8c4b6 Mon Sep 17 00:00:00 2001 From: "mark@chromium.org" Date: Thu, 27 Jun 2013 20:55:45 +0000 Subject: Fix a clang warning. Since explanatoryDialogText returns something that migth be user input, this looks like a good change anyhow. ../../breakpad/src/client/mac/sender/crash_report_sender.m:269:38: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] [self explanatoryDialogText], ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Patch by Nico Weber Review URL: https://breakpad.appspot.com/607002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1195 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/mac/sender/crash_report_sender.m | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/client') diff --git a/src/client/mac/sender/crash_report_sender.m b/src/client/mac/sender/crash_report_sender.m index c591f0ca..37eb255e 100644 --- a/src/client/mac/sender/crash_report_sender.m +++ b/src/client/mac/sender/crash_report_sender.m @@ -265,11 +265,13 @@ const int kEmailMaxLength = 64; } } else { // Create an alert panel to tell the user something happened - NSPanel* alert = NSGetAlertPanel([self shortDialogMessage], - [self explanatoryDialogText], - NSLocalizedString(@"sendReportButton", @""), - NSLocalizedString(@"cancelButton", @""), - nil); + NSPanel* alert = + NSGetAlertPanel([self shortDialogMessage], + @"%@", + NSLocalizedString(@"sendReportButton", @""), + NSLocalizedString(@"cancelButton", @""), + nil, + [self explanatoryDialogText]); // Pop the alert with an automatic timeout, and wait for the response buttonPressed = [self runModalWindow:alert withTimeout:timeout]; -- cgit v1.2.1