From cadc8ddde91cd82aa74375abb45417c75662e9b7 Mon Sep 17 00:00:00 2001 From: nealsid Date: Sun, 22 Feb 2009 01:31:43 +0000 Subject: Issue 294: mmap error checking is not correct. R=Liu git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@312 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/common/linux/dump_symbols.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/common/linux/dump_symbols.cc') diff --git a/src/common/linux/dump_symbols.cc b/src/common/linux/dump_symbols.cc index 36cd6d85..aff0d792 100644 --- a/src/common/linux/dump_symbols.cc +++ b/src/common/linux/dump_symbols.cc @@ -759,7 +759,7 @@ bool DumpSymbols::WriteSymbolFile(const std::string &obj_file, return false; void *obj_base = mmap(NULL, st.st_size, PROT_READ | PROT_WRITE, MAP_PRIVATE, obj_fd, 0); - if (!obj_base) + if (obj_base == MAP_FAILED) return false; MmapWrapper map_wrapper(obj_base, st.st_size); ElfW(Ehdr) *elf_header = reinterpret_cast(obj_base); -- cgit v1.2.1