From c7522272ffafa9b162f135aaee5d02a8895fcb0b Mon Sep 17 00:00:00 2001 From: Nelson Billing Date: Thu, 27 Feb 2020 14:04:01 -0800 Subject: Add "type" option to sym_upload sym-upload-v2 mode. - "sym-upload-v2" protocol now supports specifying a symbol file "type". - Known types are "breakpad" (default option, previously this was only effectively the only option), "elf", "pe", "macho", "debug_only", "dwp", "pdb", and "dsym". - When type other than breakpad is specified, sym_upload tool requires the code_file and debug_id value (that it otherwise would have gotten from the text of the Breakpad symbol file). - This ultimately means that sym_upload can be used to upload native symbol files now, in addition to Breakpad symbol files. Change-Id: I3a331ba16f199d1d0025df735716ba5de298f522 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2078670 Reviewed-by: Mark Mentovai --- src/common/linux/symbol_collector_client.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/common/linux/symbol_collector_client.cc') diff --git a/src/common/linux/symbol_collector_client.cc b/src/common/linux/symbol_collector_client.cc index ea995c4b..92b25ddb 100644 --- a/src/common/linux/symbol_collector_client.cc +++ b/src/common/linux/symbol_collector_client.cc @@ -102,7 +102,8 @@ CompleteUploadResult SymbolCollectorClient::CompleteUpload( const string& api_key, const string& upload_key, const string& debug_file, - const string& debug_id) { + const string& debug_id, + const string& type) { string header, response; long response_code; @@ -113,7 +114,8 @@ CompleteUploadResult SymbolCollectorClient::CompleteUpload( string body = "{ symbol_id: {" "debug_file: \"" + debug_file + "\", " - "debug_id: \"" + debug_id + "\" } }"; + "debug_id: \"" + debug_id + "\" }, " + "symbol_upload_type: \"" + type + "\" }"; if (!libcurl_wrapper->SendSimplePostRequest(url, body, -- cgit v1.2.1