From 072f86ca83bb7138fe33f10b6380badd9ef7f065 Mon Sep 17 00:00:00 2001 From: Tobias Sargeant Date: Wed, 18 Oct 2017 16:39:09 +0100 Subject: Provide helper wrappers for basename(3) and dirname(3) This hides the need to provide mutable C strings, and unifies existing basename calls and variations in a single location. Change-Id: Idfb449c47b1421f1a751efc3d7404f15f8b369ca Reviewed-on: https://chromium-review.googlesource.com/725731 Reviewed-by: Mark Mentovai Reviewed-by: Mike Frysinger --- src/common/mac/dump_syms.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/common/mac') diff --git a/src/common/mac/dump_syms.cc b/src/common/mac/dump_syms.cc index eb927292..66757cda 100644 --- a/src/common/mac/dump_syms.cc +++ b/src/common/mac/dump_syms.cc @@ -38,7 +38,6 @@ #include #include #include -#include #include #include #include @@ -60,6 +59,7 @@ #include "common/mac/arch_utilities.h" #include "common/mac/macho_reader.h" #include "common/module.h" +#include "common/path_helper.h" #include "common/scoped_ptr.h" #include "common/stabs_reader.h" #include "common/stabs_to_module.h" @@ -370,8 +370,7 @@ bool DumpSymbols::CreateEmptyModule(scoped_ptr& module) { } // Compute a module name, to appear in the MODULE record. - string module_name = object_filename_; - module_name = basename(&module_name[0]); + string module_name = google_breakpad::BaseName(object_filename_); // Choose an identifier string, to appear in the MODULE record. string identifier = Identifier(); -- cgit v1.2.1