From bad70be095dd93ecc9c28bab90bed0c86fbdedca Mon Sep 17 00:00:00 2001 From: "qsr@chromium.org" Date: Wed, 23 Nov 2011 14:22:05 +0000 Subject: Correct compilation warning. 1) Modify src/common/mac/macho_walker.cc to remove a signed vs unsigned comparison. 2) Replace mktemp in test using AutoTmpDir that has been moved from client/mac/tests to common/tests. Review URL: http://breakpad.appspot.com/328001 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@888 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/common/mac/macho_walker.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/common/mac') diff --git a/src/common/mac/macho_walker.cc b/src/common/mac/macho_walker.cc index 26535bc2..92da7b1f 100644 --- a/src/common/mac/macho_walker.cc +++ b/src/common/mac/macho_walker.cc @@ -105,9 +105,11 @@ bool MachoWalker::WalkHeader(int cpu_type) { bool MachoWalker::ReadBytes(void *buffer, size_t size, off_t offset) { if (memory_) { + if (offset < 0) + return false; bool result = true; if (offset + size > memory_size_) { - if (offset >= memory_size_) + if (static_cast(offset) >= memory_size_) return false; size = memory_size_ - offset; result = false; -- cgit v1.2.1