From 47cd498384fdf7e54b0c8a6678c8af6a71635d0f Mon Sep 17 00:00:00 2001 From: Mark Mentovai Date: Mon, 2 Dec 2019 13:45:36 -0500 Subject: dump_syms: handle forward reference DWARF attributes DW_AT_specification and DW_AT_abstract_origin attributes carry references to other DIEs. Nothing prevents the DIEs referred to from appearing later in .debug_info than the DIE containing the referring attribute, but dump_syms incompletly implemented its handling of these references, and was only able to resolve them when they were back-references. This will fix the chronic warnings produced by dump_syms of the form: dump_syms: the DIE at offset has a {DW_AT_specification, DW_AT_abstract_origin} attribute referring to the die at offset , which either was not marked as {a declaration, an inline}, or comes later in the file Patch by Greg Clayton Bug: breakpad:441 Change-Id: I98957d64a234c22afb6d0153f1bdc09e6a600b1d Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1946706 Reviewed-by: Mark Mentovai --- src/common/module.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/common/module.h') diff --git a/src/common/module.h b/src/common/module.h index db8dabd5..7309cedd 100644 --- a/src/common/module.h +++ b/src/common/module.h @@ -106,7 +106,7 @@ class Module { } // The function's name. - const string name; + string name; // The start address and the address ranges covered by the function. const Address address; -- cgit v1.2.1