From cadc8ddde91cd82aa74375abb45417c75662e9b7 Mon Sep 17 00:00:00 2001 From: nealsid Date: Sun, 22 Feb 2009 01:31:43 +0000 Subject: Issue 294: mmap error checking is not correct. R=Liu git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@312 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/common/solaris/dump_symbols.cc | 2 +- src/common/solaris/file_id.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/common/solaris') diff --git a/src/common/solaris/dump_symbols.cc b/src/common/solaris/dump_symbols.cc index df1c5b09..a0697ff9 100644 --- a/src/common/solaris/dump_symbols.cc +++ b/src/common/solaris/dump_symbols.cc @@ -650,7 +650,7 @@ bool DumpSymbols::WriteSymbolFile(const std::string &obj_file, int sym_fd) { return false; void *obj_base = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, obj_fd, 0); - if (!obj_base) + if (obj_base == MAP_FAILED)) return false; MmapWrapper map_wrapper(obj_base, st.st_size); GElf_Ehdr elf_header; diff --git a/src/common/solaris/file_id.cc b/src/common/solaris/file_id.cc index 92e7f71f..643a1462 100644 --- a/src/common/solaris/file_id.cc +++ b/src/common/solaris/file_id.cc @@ -151,7 +151,7 @@ bool FileID::ElfFileIdentifier(unsigned char identifier[16]) { return false; void *base = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0); - if (!base) + if (base == MAP_FAILED) return false; bool success = false; -- cgit v1.2.1