From b0ec96cee2ab186c9e7e480d03751588f0640bf1 Mon Sep 17 00:00:00 2001 From: jimblandy Date: Wed, 5 May 2010 17:09:20 +0000 Subject: Breakpad Linux dumper: Make StabsReader independent of endianness and word size. StabsReader simply applies a reinterpret_cast to treat the stab entry data as an array of 'struct nlist' structures, making the parser specific on the host endianness, word size, and alignment rules. On Mac OS X, a single fat binary file may contain object files of different ABIs, of which the user chooses one at run time. This patch changes the parser to read the data using the google_breakpad:: ByteCursor class, which can handle different endiannesses and word sizes. The StabsReader constructor now takes arguments indicating the endianness of the data and the size of each entry's value field. The patch changes src/common/linux/dump_symbols.cc to pass the new argument. This patch changes the StabsReader unit tests to use the google_breakpad:: TestAssembler classes to generate test data, rather than reading it from a file. This makes it easy to generate test data in various endiannesses and word sizes. It also adds tests for the new parser behaviors. a=jimblandy, r=thestig git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@583 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/common/testdata/stabs_reader_unittest.input4 | 1 - 1 file changed, 1 deletion(-) delete mode 100644 src/common/testdata/stabs_reader_unittest.input4 (limited to 'src/common/testdata/stabs_reader_unittest.input4') diff --git a/src/common/testdata/stabs_reader_unittest.input4 b/src/common/testdata/stabs_reader_unittest.input4 deleted file mode 100644 index dfdbf677..00000000 --- a/src/common/testdata/stabs_reader_unittest.input4 +++ /dev/null @@ -1 +0,0 @@ -SO 10 11 0x12 build-directory/ -- cgit v1.2.1