From 897a12cd26ad01a5ef19474f23cfd0fbff4ea5a7 Mon Sep 17 00:00:00 2001 From: Mike Wittman Date: Mon, 11 Dec 2017 13:50:41 -0800 Subject: Write field indicating multiple symbols at an address in dump_syms Updates dump_syms to write the optional 'm' first field in FUNCTION and PUBLIC records to indicate that the address corresponds to more than one symbol. Bug: google-breakpad:751 Change-Id: I850b0122324ed5f9ec747aa92ba354a3126a7ef9 Reviewed-on: https://chromium-review.googlesource.com/820711 Reviewed-by: Mark Mentovai --- src/common/windows/pdb_source_line_writer.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'src/common/windows/pdb_source_line_writer.h') diff --git a/src/common/windows/pdb_source_line_writer.h b/src/common/windows/pdb_source_line_writer.h index 5a8bcbe7..3ed07361 100644 --- a/src/common/windows/pdb_source_line_writer.h +++ b/src/common/windows/pdb_source_line_writer.h @@ -92,9 +92,7 @@ class PDBSourceLineWriter { ANY_FILE // try PDB_FILE and then EXE_FILE }; - // NB: |enable_multiple_field| is temporary while transitioning to enabling - // writing the multiple field permanently. - explicit PDBSourceLineWriter(bool enable_multiple_field = false); + explicit PDBSourceLineWriter(); ~PDBSourceLineWriter(); // Opens the given file. For executable files, the corresponding pdb @@ -232,10 +230,6 @@ class PDBSourceLineWriter { // a failure, returns 0, which is also a valid number of bytes. static int GetFunctionStackParamSize(IDiaSymbol *function); - // True if the optional 'm' field on FUNC and PUBLIC for multiple symbols at - // the same address should be output. - bool enable_multiple_field_; - // The filename of the PE file corresponding to the currently-open // pdb file. wstring code_file_; -- cgit v1.2.1