From 6ca3f8bbe56951db922fa3b567d7ec441093f96e Mon Sep 17 00:00:00 2001 From: Nelson Billing Date: Mon, 24 Jun 2019 11:52:48 -0700 Subject: Add PE-only MD support to Windows symbol converter. - Only 64-bit PEs supported. - Re-add some scripts that were missed in initial move of code. - Change msdia120.dll dependency to msdia140.dll. - Add tests for Intel, AMD, and NVidia Microsoft Symbol Stores. - Windows symbol converter now attempts to fall back to PE-only metadata when it fails to locate a PDB. - Remove the 'binary' folder under converter_exe. Need to think more about how a deployment should look and what tool(s) to use in creating one. Change-Id: I52e42cbe5e759874a25114c2483e8b50d73fdf77 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1670098 Reviewed-by: Ivan Penkov --- src/common/windows/pe_util.cc | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/common') diff --git a/src/common/windows/pe_util.cc b/src/common/windows/pe_util.cc index 27f702a3..f599fb53 100644 --- a/src/common/windows/pe_util.cc +++ b/src/common/windows/pe_util.cc @@ -143,10 +143,6 @@ bool ReadModuleInfo(const wstring & pe_file, PDBModuleInfo * info) { PIMAGE_OPTIONAL_HEADER64 optional_header = &(reinterpret_cast(img->FileHeader))->OptionalHeader; - if (optional_header->Magic != IMAGE_NT_OPTIONAL_HDR64_MAGIC) { - fprintf(stderr, "Not a PE32+ image\n"); - return false; - } // Search debug directories for a guid signature & age DWORD debug_rva = optional_header-> -- cgit v1.2.1