From 63919583ba0d302a2ceb437ecf41a7975f44f54b Mon Sep 17 00:00:00 2001 From: "ivanpe@chromium.org" Date: Tue, 25 Nov 2014 22:45:23 +0000 Subject: Surfacing the process create time in google_breakpad::ProcessState and updating minidump_stackwalk to show process uptime. I tested this with a minidump from Chrome and I got a result that is inline with what the Windows debugger is showing for that dump: minidump_stackwalk output: -------------------------- Process uptime: 601 seconds WinDBG output: -------------- Process Uptime: 0 days 0:10:01.000 I didn't update the machine readable output of minidump_stackwalk on purpose in order to avoid breaking someone that uses it. It can be added later to the machine output if needed. R=mark@chromium.org Review URL: https://breakpad.appspot.com/7754002 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1406 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/google_breakpad/processor/minidump.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'src/google_breakpad/processor/minidump.h') diff --git a/src/google_breakpad/processor/minidump.h b/src/google_breakpad/processor/minidump.h index 34e28312..51f15025 100644 --- a/src/google_breakpad/processor/minidump.h +++ b/src/google_breakpad/processor/minidump.h @@ -732,6 +732,7 @@ class MinidumpMiscInfo : public MinidumpStream { private: friend class Minidump; + friend class TestMinidumpMiscInfo; static const uint32_t kStreamType = MD_MISC_INFO_STREAM; @@ -902,14 +903,14 @@ class Minidump { // to avoid exposing an ugly API (GetStream needs to accept a garbage // parameter). virtual MinidumpThreadList* GetThreadList(); - MinidumpModuleList* GetModuleList(); + virtual MinidumpModuleList* GetModuleList(); virtual MinidumpMemoryList* GetMemoryList(); - MinidumpException* GetException(); - MinidumpAssertion* GetAssertion(); + virtual MinidumpException* GetException(); + virtual MinidumpAssertion* GetAssertion(); virtual MinidumpSystemInfo* GetSystemInfo(); - MinidumpMiscInfo* GetMiscInfo(); - MinidumpBreakpadInfo* GetBreakpadInfo(); - MinidumpMemoryInfoList* GetMemoryInfoList(); + virtual MinidumpMiscInfo* GetMiscInfo(); + virtual MinidumpBreakpadInfo* GetBreakpadInfo(); + virtual MinidumpMemoryInfoList* GetMemoryInfoList(); // The next set of methods are provided for users who wish to access // data in minidump files directly, while leveraging the rest of -- cgit v1.2.1