From b64d76a3b8a692f431d440f6a4416e7c70aad4ef Mon Sep 17 00:00:00 2001 From: jimblandy Date: Wed, 23 Dec 2009 22:32:14 +0000 Subject: Issue 49012: Breakpad Processor: Rename 'StackFrameInfo' structure to 'WindowsFrameInfo'. Also, rename stack_frame_info.h to windows_frame_info.h. If it seems odd to have functions like FillSourceLineInfo returning Windows-specific data structures... well, it is! This patch just makes it more obvious what's going on. a=jimblandy, r=nealsid git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@471 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/google_breakpad/processor/basic_source_line_resolver.h | 2 +- src/google_breakpad/processor/source_line_resolver_interface.h | 6 +++--- src/google_breakpad/processor/stackwalker.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/google_breakpad/processor') diff --git a/src/google_breakpad/processor/basic_source_line_resolver.h b/src/google_breakpad/processor/basic_source_line_resolver.h index c01cc685..55902248 100644 --- a/src/google_breakpad/processor/basic_source_line_resolver.h +++ b/src/google_breakpad/processor/basic_source_line_resolver.h @@ -63,7 +63,7 @@ class BasicSourceLineResolver : public SourceLineResolverInterface { virtual bool HasModule(const string &module_name) const; - virtual StackFrameInfo* FillSourceLineInfo(StackFrame *frame) const; + virtual WindowsFrameInfo* FillSourceLineInfo(StackFrame *frame) const; private: template class MemAddrMap; diff --git a/src/google_breakpad/processor/source_line_resolver_interface.h b/src/google_breakpad/processor/source_line_resolver_interface.h index 93ef85d2..a139cf07 100644 --- a/src/google_breakpad/processor/source_line_resolver_interface.h +++ b/src/google_breakpad/processor/source_line_resolver_interface.h @@ -40,7 +40,7 @@ namespace google_breakpad { using std::string; struct StackFrame; -struct StackFrameInfo; +struct WindowsFrameInfo; class SourceLineResolverInterface { public: @@ -68,9 +68,9 @@ class SourceLineResolverInterface { // module_name fields must already be filled in. Additional debugging // information, if available, is returned. If the information is not // available, returns NULL. A NULL return value does not indicate an - // error. The caller takes ownership of any returned StackFrameInfo + // error. The caller takes ownership of any returned WindowsFrameInfo // object. - virtual StackFrameInfo* FillSourceLineInfo(StackFrame *frame) const = 0; + virtual WindowsFrameInfo* FillSourceLineInfo(StackFrame *frame) const = 0; protected: // SourceLineResolverInterface cannot be instantiated except by subclasses diff --git a/src/google_breakpad/processor/stackwalker.h b/src/google_breakpad/processor/stackwalker.h index 90274aae..27085585 100644 --- a/src/google_breakpad/processor/stackwalker.h +++ b/src/google_breakpad/processor/stackwalker.h @@ -53,7 +53,7 @@ class MemoryRegion; class MinidumpContext; class SourceLineResolverInterface; struct StackFrame; -struct StackFrameInfo; +struct WindowsFrameInfo; class SymbolSupplier; class SystemInfo; @@ -135,7 +135,7 @@ class Stackwalker { // the caller. virtual StackFrame* GetCallerFrame( const CallStack *stack, - const vector< linked_ptr > &stack_frame_info) = 0; + const vector< linked_ptr > &stack_frame_info) = 0; // The optional SymbolSupplier for resolving source line info. SymbolSupplier *supplier_; -- cgit v1.2.1