From 1d8752bf0f710ebad7fb23a97bf1364b680e0961 Mon Sep 17 00:00:00 2001 From: "benchan@chromium.org" Date: Fri, 30 Mar 2012 21:01:09 +0000 Subject: Fix memory leak in DisassemblerX86. A memory leak in DisassemblerX86 is detected by valgrind. This patch fixes the DisassemblerX86 destructor to properly free the |current_instr_| variable. BUG=471 TEST=Run valgrind on disassembler_x86_unittest to verify the leak is gone. Review URL: https://breakpad.appspot.com/371001 git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@940 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/processor/disassembler_x86.cc | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/processor/disassembler_x86.cc') diff --git a/src/processor/disassembler_x86.cc b/src/processor/disassembler_x86.cc index 7e41e4bf..45a235db 100644 --- a/src/processor/disassembler_x86.cc +++ b/src/processor/disassembler_x86.cc @@ -48,6 +48,9 @@ DisassemblerX86::DisassemblerX86(const u_int8_t *bytecode, } DisassemblerX86::~DisassemblerX86() { + if (instr_valid_) + libdis::x86_oplist_free(¤t_instr_); + libdis::x86_cleanup(); } -- cgit v1.2.1