From 09b056975dacd1f0f815ad820b6dc9913b0118a3 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 23 Jun 2020 18:55:43 -0400 Subject: fix pointer style to match the style guide We do this in a lot of places, but we're inconsistent. Normalize the code to the Google C++ style guide. Change-Id: Ic2aceab661ce8f6b993dda21b1cdf5d2198dcbbf Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2262932 Reviewed-by: Sterling Augustine Reviewed-by: Mark Mentovai --- src/processor/exploitability_linux.h | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'src/processor/exploitability_linux.h') diff --git a/src/processor/exploitability_linux.h b/src/processor/exploitability_linux.h index e3ff13b6..36647959 100644 --- a/src/processor/exploitability_linux.h +++ b/src/processor/exploitability_linux.h @@ -44,8 +44,8 @@ namespace google_breakpad { class ExploitabilityLinux : public Exploitability { public: - ExploitabilityLinux(Minidump *dump, - ProcessState *process_state); + ExploitabilityLinux(Minidump* dump, + ProcessState* process_state); // Parameters are the minidump to analyze, the object representing process // state, and whether to enable objdump disassembly. @@ -53,8 +53,8 @@ class ExploitabilityLinux : public Exploitability { // objdump for diassembly. It is used to check the identity of the // instruction that caused the program to crash. If there are any // portability concerns, this should not be enabled. - ExploitabilityLinux(Minidump *dump, - ProcessState *process_state, + ExploitabilityLinux(Minidump* dump, + ProcessState* process_state, bool enable_objdump); virtual ExploitabilityRating CheckPlatformExploitability(); @@ -68,7 +68,7 @@ class ExploitabilityLinux : public Exploitability { // Checks the exception that triggered the creation of the // minidump and reports whether the exception suggests no exploitability. - bool BenignCrashTrigger(const MDRawExceptionStream *raw_exception_stream); + bool BenignCrashTrigger(const MDRawExceptionStream* raw_exception_stream); // This method checks if the crash occurred during a write to read-only or // invalid memory. It does so by checking if the instruction at the @@ -81,34 +81,34 @@ class ExploitabilityLinux : public Exploitability { // buffer, given the desired architecture, the file from which objdump will // read, and the buffer length. The method returns whether the disassembly // was a success, and the caller owns all pointers. - static bool DisassembleBytes(const string &architecture, - const uint8_t *raw_bytes, + static bool DisassembleBytes(const string& architecture, + const uint8_t* raw_bytes, const unsigned int MAX_OBJDUMP_BUFFER_LEN, - char *objdump_output_buffer); + char* objdump_output_buffer); // Parses the objdump output given in |objdump_output_buffer| and extracts // the line of the first instruction into |instruction_line|. Returns true // when the instruction line is successfully extracted. static bool GetObjdumpInstructionLine( - const char *objdump_output_buffer, - string *instruction_line); + const char* objdump_output_buffer, + string* instruction_line); // Tokenizes out the operation and operands from a line of instruction // disassembled by objdump. This method modifies the pointers to match the // tokens of the instruction, and returns if the tokenizing was a success. // The caller owns all pointers. - static bool TokenizeObjdumpInstruction(const string &line, - string *operation, - string *dest, - string *src); + static bool TokenizeObjdumpInstruction(const string& line, + string* operation, + string* dest, + string* src); // Calculates the effective address of an expression in the form reg+a or // reg-a, where 'reg' is a register and 'a' is a constant, and writes the // result in the pointer. The method returns whether the calculation was // a success. The caller owns the pointer. - static bool CalculateAddress(const string &address_expression, - const DumpContext &context, - uint64_t *write_address); + static bool CalculateAddress(const string& address_expression, + const DumpContext& context, + uint64_t* write_address); #endif // _WIN32 // Checks if the stack pointer points to a memory mapping that is not -- cgit v1.2.1