From 09b056975dacd1f0f815ad820b6dc9913b0118a3 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 23 Jun 2020 18:55:43 -0400 Subject: fix pointer style to match the style guide We do this in a lot of places, but we're inconsistent. Normalize the code to the Google C++ style guide. Change-Id: Ic2aceab661ce8f6b993dda21b1cdf5d2198dcbbf Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/2262932 Reviewed-by: Sterling Augustine Reviewed-by: Mark Mentovai --- src/processor/postfix_evaluator-inl.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'src/processor/postfix_evaluator-inl.h') diff --git a/src/processor/postfix_evaluator-inl.h b/src/processor/postfix_evaluator-inl.h index d7dbeac2..f567b1c8 100644 --- a/src/processor/postfix_evaluator-inl.h +++ b/src/processor/postfix_evaluator-inl.h @@ -58,19 +58,19 @@ using std::ostringstream; // before returning failure. class AutoStackClearer { public: - explicit AutoStackClearer(vector *stack) : stack_(stack) {} + explicit AutoStackClearer(vector* stack) : stack_(stack) {} ~AutoStackClearer() { stack_->clear(); } private: - vector *stack_; + vector* stack_; }; template bool PostfixEvaluator::EvaluateToken( - const string &token, - const string &expression, - DictionaryValidityType *assigned) { + const string& token, + const string& expression, + DictionaryValidityType* assigned) { // There are enough binary operations that do exactly the same thing // (other than the specific operation, of course) that it makes sense // to share as much code as possible. @@ -203,8 +203,8 @@ bool PostfixEvaluator::EvaluateToken( template bool PostfixEvaluator::EvaluateInternal( - const string &expression, - DictionaryValidityType *assigned) { + const string& expression, + DictionaryValidityType* assigned) { // Tokenize, splitting on whitespace. istringstream stream(expression); string token; @@ -231,8 +231,8 @@ bool PostfixEvaluator::EvaluateInternal( } template -bool PostfixEvaluator::Evaluate(const string &expression, - DictionaryValidityType *assigned) { +bool PostfixEvaluator::Evaluate(const string& expression, + DictionaryValidityType* assigned) { // Ensure that the stack is cleared before returning. AutoStackClearer clearer(&stack_); @@ -250,8 +250,8 @@ bool PostfixEvaluator::Evaluate(const string &expression, } template -bool PostfixEvaluator::EvaluateForValue(const string &expression, - ValueType *result) { +bool PostfixEvaluator::EvaluateForValue(const string& expression, + ValueType* result) { // Ensure that the stack is cleared before returning. AutoStackClearer clearer(&stack_); @@ -271,7 +271,7 @@ bool PostfixEvaluator::EvaluateForValue(const string &expression, template typename PostfixEvaluator::PopResult PostfixEvaluator::PopValueOrIdentifier( - ValueType *value, string *identifier) { + ValueType* value, string* identifier) { // There needs to be at least one element on the stack to pop. if (!stack_.size()) return POP_RESULT_FAIL; @@ -314,7 +314,7 @@ PostfixEvaluator::PopValueOrIdentifier( template -bool PostfixEvaluator::PopValue(ValueType *value) { +bool PostfixEvaluator::PopValue(ValueType* value) { ValueType literal = ValueType(); string token; PopResult result; @@ -343,14 +343,14 @@ bool PostfixEvaluator::PopValue(ValueType *value) { template -bool PostfixEvaluator::PopValues(ValueType *value1, - ValueType *value2) { +bool PostfixEvaluator::PopValues(ValueType* value1, + ValueType* value2) { return PopValue(value2) && PopValue(value1); } template -void PostfixEvaluator::PushValue(const ValueType &value) { +void PostfixEvaluator::PushValue(const ValueType& value) { ostringstream token_stream; token_stream << value; stack_.push_back(token_stream.str()); -- cgit v1.2.1