From 2684b4dc196ca2da9466aa5391f5c0090739d2f6 Mon Sep 17 00:00:00 2001 From: jimblandy Date: Thu, 14 Jan 2010 19:17:36 +0000 Subject: Breakpad processor: Don't pass Windows stack walking information to all walkers. At the moment, the StackWalker GetCallerFrame member function expects a vector of WindowsFrameInfo structures, even though WindowsFrameInfo is only used or useful on one one implementation (StackWalkerX86). This patch changes StackWalker::GetCallerFrame to no longer expect the WindowsFrameInfo structures, and changes all implementations to match. In particular, StackWalkerX86 is changed to find the WindowsFrameInfo data itself, and store a pointer to whatever it got in the StackFrame object itself (which is really a StackFrameX86). To allow GetCallerFrame implementations to look up stack walking data, StackWalker::resolver_ needs to be made protected, not private. a=jimblandy, r=mmentovai git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@491 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/processor/stackwalker_arm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/processor/stackwalker_arm.h') diff --git a/src/processor/stackwalker_arm.h b/src/processor/stackwalker_arm.h index b9399dd7..b149bfb7 100644 --- a/src/processor/stackwalker_arm.h +++ b/src/processor/stackwalker_arm.h @@ -64,9 +64,7 @@ class StackwalkerARM : public Stackwalker { // Implementation of Stackwalker, using arm context and stack conventions. // TODO: currently stubbed out, needs CFI symbol dumper support virtual StackFrame* GetContextFrame(); - virtual StackFrame* GetCallerFrame( - const CallStack *stack, - const vector< linked_ptr > &stack_frame_info); + virtual StackFrame* GetCallerFrame(const CallStack *stack); // Stores the CPU context corresponding to the innermost stack frame to // be returned by GetContextFrame. -- cgit v1.2.1