From bab770045bb2cdedce4046400544904fc40c6703 Mon Sep 17 00:00:00 2001 From: "SiyangXie@gmail.com" Date: Wed, 10 Oct 2012 21:41:52 +0000 Subject: Refactor the logic of resolving source line info into helper class. http://breakpad.appspot.com/459002/ git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1068 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/processor/stackwalker_arm.h | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) (limited to 'src/processor/stackwalker_arm.h') diff --git a/src/processor/stackwalker_arm.h b/src/processor/stackwalker_arm.h index 24fc60dd..eb480156 100644 --- a/src/processor/stackwalker_arm.h +++ b/src/processor/stackwalker_arm.h @@ -54,13 +54,12 @@ class StackwalkerARM : public Stackwalker { // register state corresponding to the innermost called frame to be // included in the stack. The other arguments are passed directly through // to the base Stackwalker constructor. - StackwalkerARM(const SystemInfo *system_info, - const MDRawContextARM *context, + StackwalkerARM(const SystemInfo* system_info, + const MDRawContextARM* context, int fp_register, - MemoryRegion *memory, - const CodeModules *modules, - SymbolSupplier *supplier, - SourceLineResolverInterface *resolver); + MemoryRegion* memory, + const CodeModules* modules, + StackFrameSymbolizer* frame_symbolizer); // Change the context validity mask of the frame returned by // GetContextFrame to VALID. This is only for use by unit tests; the @@ -70,25 +69,25 @@ class StackwalkerARM : public Stackwalker { private: // Implementation of Stackwalker, using arm context and stack conventions. virtual StackFrame* GetContextFrame(); - virtual StackFrame* GetCallerFrame(const CallStack *stack); + virtual StackFrame* GetCallerFrame(const CallStack* stack); // Use cfi_frame_info (derived from STACK CFI records) to construct // the frame that called frames.back(). The caller takes ownership // of the returned frame. Return NULL on failure. - StackFrameARM *GetCallerByCFIFrameInfo(const vector &frames, - CFIFrameInfo *cfi_frame_info); + StackFrameARM* GetCallerByCFIFrameInfo(const vector &frames, + CFIFrameInfo* cfi_frame_info); // Use the frame pointer. The caller takes ownership of the returned frame. // Return NULL on failure. - StackFrameARM *GetCallerByFramePointer(const vector &frames); + StackFrameARM* GetCallerByFramePointer(const vector &frames); // Scan the stack for plausible return addresses. The caller takes ownership // of the returned frame. Return NULL on failure. - StackFrameARM *GetCallerByStackScan(const vector &frames); + StackFrameARM* GetCallerByStackScan(const vector &frames); // Stores the CPU context corresponding to the youngest stack frame, to // be returned by GetContextFrame. - const MDRawContextARM *context_; + const MDRawContextARM* context_; // The register to use a as frame pointer. The value is -1 if frame pointer // cannot be used. -- cgit v1.2.1