From a875991e73835d2ad3ba277b53b8121fd1ee06ab Mon Sep 17 00:00:00 2001 From: Tao Bai Date: Fri, 13 May 2016 12:45:44 -0400 Subject: Revert "Write adjusted range back to module" This is no right fix, we shouldn't allow module overlap. This reverts commit 4f417c8c0ffceb6c2516c6ef00cd91ca5746d852. BUG=606972 R=mark@chromium.org Review URL: https://codereview.chromium.org/1976683004 . Patch from Tao Bai . --- src/processor/minidump.cc | 8 -------- 1 file changed, 8 deletions(-) (limited to 'src/processor') diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc index c026559b..84f013d0 100644 --- a/src/processor/minidump.cc +++ b/src/processor/minidump.cc @@ -2327,13 +2327,6 @@ const MDImageDebugMisc* MinidumpModule::GetMiscRecord(uint32_t* size) { return reinterpret_cast(&(*misc_record_)[0]); } -void MinidumpModule::set_base_address_and_size(uint64_t base_address, - uint64_t size) { - if (valid_) { - module_.base_of_image = base_address; - module_.size_of_image = size; - } -} void MinidumpModule::Print() { if (!valid_) { @@ -2642,7 +2635,6 @@ bool MinidumpModuleList::Read(uint32_t expected_size) { HexString(module_size) << ", after adjusting"; return false; } - module->set_base_address_and_size(base_address, module_size); } else { BPLOG(ERROR) << "MinidumpModuleList could not store module " << module_index << "/" << module_count << ", " << -- cgit v1.2.1