From ebba1800e4bb5ffad3533e6bf01978b578eea91a Mon Sep 17 00:00:00 2001 From: Ivan Penkov Date: Fri, 11 Mar 2016 16:37:46 -0800 Subject: Explicitly call non-sized delete on dynamically sized memory for correct behavior under sized-delete. The code as it stands allocates a chunk of memory of arbitrary size and places an object into it. It stores a pointer to that object and memory into a list telling the compiler that it is a pointer to a char. When the compiler deletes the objects in the list it thinks that the list contains pointers to chars - not pointers to arbitrarily sized regions of memory. This is fixing an issue that will reproduces when the following optimization (C++ sized dealocation) is enabled: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3536.html The fix is to explicitly call the non-sized delete operator, and the library code that supports malloc/free/new/delete will figure out the size of the block of memory from the pointer being passed in. Patch provided by Darryl Gove. R=mark@chromium.org Review URL: https://codereview.chromium.org/1788473002 . --- src/processor/static_map_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/processor') diff --git a/src/processor/static_map_unittest.cc b/src/processor/static_map_unittest.cc index 97b1e61a..393d43d5 100644 --- a/src/processor/static_map_unittest.cc +++ b/src/processor/static_map_unittest.cc @@ -180,7 +180,7 @@ class TestValidMap : public ::testing::Test { void TearDown() { for (int i = 0;i < kNumberTestCases; ++i) - delete map_data[i]; + ::operator delete(map_data[i]); } -- cgit v1.2.1