From 561f81873562d407ac1c39144b30e26163e0045d Mon Sep 17 00:00:00 2001 From: "rmcilroy@chromium.org" Date: Tue, 22 Jul 2014 11:34:11 +0000 Subject: Chrome on Android now supports loading the shared library directly from the APK file. This patch makes two changes to breakpad to enable crash reporting to work correctly when the library is inside another file (an archive): - Do not filter mappings which map an executable at a non-zero offset. - If such an executable is mapped look in the ELF information for the shared object name and use that name in the minidump. Note this change doesn't care about the archive format and isn't Android specific (though loading the shared library this way is currently only done on Android). BUG=390618 R=thestig@chromium.org Review URL: https://breakpad.appspot.com/7684002 Patch from Anton Carver . git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1355 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/tools/linux/md2core/minidump-2-core.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/tools/linux/md2core') diff --git a/src/tools/linux/md2core/minidump-2-core.cc b/src/tools/linux/md2core/minidump-2-core.cc index 92bd41e7..815e6e75 100644 --- a/src/tools/linux/md2core/minidump-2-core.cc +++ b/src/tools/linux/md2core/minidump-2-core.cc @@ -997,7 +997,7 @@ main(int argc, char** argv) { if (argc != argi + 1) return usage(argv[0]); - MemoryMappedFile mapped_file(argv[argi]); + MemoryMappedFile mapped_file(argv[argi], 0); if (!mapped_file.data()) { fprintf(stderr, "Failed to mmap dump file\n"); return 1; -- cgit v1.2.1