From 6ca3f8bbe56951db922fa3b567d7ec441093f96e Mon Sep 17 00:00:00 2001 From: Nelson Billing Date: Mon, 24 Jun 2019 11:52:48 -0700 Subject: Add PE-only MD support to Windows symbol converter. - Only 64-bit PEs supported. - Re-add some scripts that were missed in initial move of code. - Change msdia120.dll dependency to msdia140.dll. - Add tests for Intel, AMD, and NVidia Microsoft Symbol Stores. - Windows symbol converter now attempts to fall back to PE-only metadata when it fails to locate a PDB. - Remove the 'binary' folder under converter_exe. Need to think more about how a deployment should look and what tool(s) to use in creating one. Change-Id: I52e42cbe5e759874a25114c2483e8b50d73fdf77 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1670098 Reviewed-by: Ivan Penkov --- src/tools/windows/converter_exe/configure.cmd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/tools/windows/converter_exe/configure.cmd') diff --git a/src/tools/windows/converter_exe/configure.cmd b/src/tools/windows/converter_exe/configure.cmd index 39b1d2a5..5464a61e 100644 --- a/src/tools/windows/converter_exe/configure.cmd +++ b/src/tools/windows/converter_exe/configure.cmd @@ -18,10 +18,10 @@ REM ****************************************************************** pushd %SCRIPT_LOCATION% REM ****************************************************************** -REM Register msdia120.dll. +REM Register msdia140.dll. REM ****************************************************************** -SET MSG=Failed to register msdia120.dll. Make sure to run this in elevated command prompt. -%systemroot%\SysWoW64\regsvr32.exe /s msdia120.dll & if errorlevel 1 echo %MSG% & goto :fail +SET MSG=Failed to register msdia140.dll. Make sure to run this in elevated command prompt. +%systemroot%\SysWoW64\regsvr32.exe /s msdia140.dll & if errorlevel 1 echo %MSG% & goto :fail :success echo Configuration was successful. -- cgit v1.2.1