From a5a607b0b01c7022d7ccba282491c40da204cba2 Mon Sep 17 00:00:00 2001 From: Nelson Billing Date: Thu, 27 Jun 2019 12:47:45 -0700 Subject: Fix clang build warnings/errors for windows symbol converter. Change-Id: Ib7f6e37af1466b5bed3e7d2921e0d9774394ad1e Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1680056 Reviewed-by: Mark Mentovai --- src/tools/windows/converter_exe/escaping.cc | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/tools/windows/converter_exe/escaping.cc') diff --git a/src/tools/windows/converter_exe/escaping.cc b/src/tools/windows/converter_exe/escaping.cc index e26bbeb3..74a7203a 100644 --- a/src/tools/windows/converter_exe/escaping.cc +++ b/src/tools/windows/converter_exe/escaping.cc @@ -259,10 +259,10 @@ int Base64UnescapeInternal(const char *src, int szsrc, // szsrc claims the string is). if (!src[0] || !src[1] || !src[2] || - (temp = ((unbase64[src[0]] << 18) | - (unbase64[src[1]] << 12) | - (unbase64[src[2]] << 6) | - (unbase64[src[3]]))) & 0x80000000) { + (temp = ((unbase64[static_cast(src[0])] << 18) | + (unbase64[static_cast(src[1])] << 12) | + (unbase64[static_cast(src[2])] << 6) | + (unbase64[static_cast(src[3])]))) & 0x80000000) { // Iff any of those four characters was bad (null, illegal, // whitespace, padding), then temp's high bit will be set // (because unbase64[] is -1 for all bad characters). @@ -301,10 +301,10 @@ int Base64UnescapeInternal(const char *src, int szsrc, } else { while (szsrc >= 4) { if (!src[0] || !src[1] || !src[2] || - (temp = ((unbase64[src[0]] << 18) | - (unbase64[src[1]] << 12) | - (unbase64[src[2]] << 6) | - (unbase64[src[3]]))) & 0x80000000) { + (temp = ((unbase64[static_cast(src[0])] << 18) | + (unbase64[static_cast(src[1])] << 12) | + (unbase64[static_cast(src[2])] << 6) | + (unbase64[static_cast(src[3])]))) & 0x80000000) { GET_INPUT(first_no_dest, 4); GET_INPUT(second_no_dest, 3); GET_INPUT(third_no_dest, 2); -- cgit v1.2.1