From 638066b82e913e681d887e4561d9984e6a3af1c8 Mon Sep 17 00:00:00 2001 From: Yunlian Jiang Date: Wed, 4 May 2016 16:48:00 -0700 Subject: breakpad: fix unittest errors This fixes the unittest error caused by https://codereview.chromium.org/1884283002/ TEST=unittest passes on falco board in ChromeOS. BUG= R=vapier@chromium.org Review URL: https://codereview.chromium.org/1952083002 . --- src/client/linux/handler/exception_handler_unittest.cc | 4 ---- src/common/dwarf/dwarf2reader_die_unittest.cc | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/client/linux/handler/exception_handler_unittest.cc b/src/client/linux/handler/exception_handler_unittest.cc index 4eb7b73c..17d84cf7 100644 --- a/src/client/linux/handler/exception_handler_unittest.cc +++ b/src/client/linux/handler/exception_handler_unittest.cc @@ -93,10 +93,6 @@ void FlushInstructionCache(const char* memory, uint32_t memory_size) { #endif } -// Length of a formatted GUID string = -// sizeof(MDGUID) * 2 + 4 (for dashes) + 1 (null terminator) -const int kGUIDStringSize = 37; - void sigchld_handler(int signo) { } int CreateTMPFile(const string& dir, string* path) { diff --git a/src/common/dwarf/dwarf2reader_die_unittest.cc b/src/common/dwarf/dwarf2reader_die_unittest.cc index b53104fb..71418eb8 100644 --- a/src/common/dwarf/dwarf2reader_die_unittest.cc +++ b/src/common/dwarf/dwarf2reader_die_unittest.cc @@ -199,7 +199,7 @@ TEST_P(DwarfHeader, Header) { ByteReader byte_reader(GetParam().endianness == kLittleEndian ? ENDIANNESS_LITTLE : ENDIANNESS_BIG); - CompilationUnit parser(MakeSectionMap(), 0, &byte_reader, &handler); + CompilationUnit parser("", MakeSectionMap(), 0, &byte_reader, &handler); EXPECT_EQ(parser.Start(), info_contents.size()); } @@ -277,7 +277,7 @@ struct DwarfFormsFixture: public DIEFixture { void ParseCompilationUnit(const DwarfHeaderParams ¶ms, uint64 offset=0) { ByteReader byte_reader(params.endianness == kLittleEndian ? ENDIANNESS_LITTLE : ENDIANNESS_BIG); - CompilationUnit parser(MakeSectionMap(), offset, &byte_reader, &handler); + CompilationUnit parser("", MakeSectionMap(), offset, &byte_reader, &handler); EXPECT_EQ(offset + parser.Start(), info_contents.size()); } -- cgit v1.2.1