diff options
| author | Andrea Diamantini <adjam7@gmail.com> | 2010-07-04 16:15:50 +0200 |
|---|---|---|
| committer | Andrea Diamantini <adjam7@gmail.com> | 2010-07-04 16:15:50 +0200 |
| commit | 3b351d7a17dbfa75dfe8521b9611a98efb34fd6e (patch) | |
| tree | 28f8e5b890ac21155263c2e23183e87b40420f02 | |
| parent | fix tab preview when tab has never been focused. (old bug, fixed, reintroduce... (diff) | |
| download | rekonq-3b351d7a17dbfa75dfe8521b9611a98efb34fd6e.tar.xz | |
Clean MainView API and fix "Pano's bug" about opening new tabs near current ons
| -rw-r--r-- | src/application.cpp | 4 | ||||
| -rw-r--r-- | src/mainview.cpp | 4 | ||||
| -rw-r--r-- | src/mainview.h | 3 | ||||
| -rw-r--r-- | src/webpage.cpp | 2 |
4 files changed, 6 insertions, 7 deletions
diff --git a/src/application.cpp b/src/application.cpp index e58e8843..5b98fafa 100644 --- a/src/application.cpp +++ b/src/application.cpp @@ -366,7 +366,7 @@ void Application::loadUrl(const KUrl& url, const Rekonq::OpenType& type) { case Rekonq::NewTab: if( ReKonfig::openTabNoWindow() ) - tab = w->mainView()->newWebTab(!ReKonfig::openTabsBack(), ReKonfig::openTabsNearCurrent()); + tab = w->mainView()->newWebTab( !ReKonfig::openTabsBack() ); else { w = newMainWindow(); @@ -377,7 +377,7 @@ void Application::loadUrl(const KUrl& url, const Rekonq::OpenType& type) tab = w->mainView()->newWebTab(true); break; case Rekonq::NewBackTab: - tab = w->mainView()->newWebTab(false, ReKonfig::openTabsNearCurrent()); + tab = w->mainView()->newWebTab(false); break; case Rekonq::NewWindow: case Rekonq::CurrentTab: diff --git a/src/mainview.cpp b/src/mainview.cpp index 5b2408da..1f252696 100644 --- a/src/mainview.cpp +++ b/src/mainview.cpp @@ -318,7 +318,7 @@ WebTab *MainView::webTab(int index) const } -WebTab *MainView::newWebTab(bool focused, bool nearParent) +WebTab *MainView::newWebTab(bool focused) { WebTab* tab = new WebTab(this); UrlBar *bar = new UrlBar(tab); @@ -335,7 +335,7 @@ WebTab *MainView::newWebTab(bool focused, bool nearParent) connect(tab->view()->page(), SIGNAL(windowCloseRequested()), this, SLOT(windowCloseRequested())); connect(tab->view()->page(), SIGNAL(printRequested(QWebFrame *)), this, SIGNAL(printRequested(QWebFrame *))); - if (nearParent) + if ( ReKonfig::openTabsNearCurrent() ) { insertTab(currentIndex() + 1, tab, i18n("(Untitled)")); _widgetBar->insertWidget(currentIndex() + 1, bar); diff --git a/src/mainview.h b/src/mainview.h index f0a1982f..2ece6fe4 100644 --- a/src/mainview.h +++ b/src/mainview.h @@ -96,10 +96,9 @@ public: * with a webview inside * @param focused decide if you wannna give focus * (or not) to this new tab (default true) - * @param nearParent decide if you wanna create new tab near current or not * @return the webview embedded in the new tab */ - WebTab *newWebTab(bool focused = true, bool nearParent = false); + WebTab *newWebTab(bool focused = true); inline QList<HistoryItem> recentlyClosedTabs() { return m_recentlyClosedTabs; } diff --git a/src/webpage.cpp b/src/webpage.cpp index 9e539f7a..939d7128 100644 --- a/src/webpage.cpp +++ b/src/webpage.cpp @@ -294,7 +294,7 @@ WebPage *WebPage::createWindow(QWebPage::WebWindowType type) WebTab *w = 0; if (ReKonfig::openTabNoWindow()) { - w = Application::instance()->mainWindow()->mainView()->newWebTab(!ReKonfig::openTabsBack(), ReKonfig::openTabsNearCurrent()); + w = Application::instance()->mainWindow()->mainView()->newWebTab( !ReKonfig::openTabsBack() ); } else { |