diff options
| author | Benjamin Poulain <ikipou@gmail.com> | 2010-11-13 16:47:20 +0100 |
|---|---|---|
| committer | Benjamin Poulain <benjamin.poulain@nokia.com> | 2010-11-20 18:53:09 +0100 |
| commit | eba8b17b2514c39897b035a1f5529f5b87a7b114 (patch) | |
| tree | b66e0bd03b5cf07fe46dcb63027c1f0e1839a5bf | |
| parent | Make the invariants of MainView explicit (diff) | |
| download | rekonq-eba8b17b2514c39897b035a1f5529f5b87a7b114.tar.xz | |
Remove m_loadingGitPath from MainView
The attribute m_loadingGitPath is an invariant of runtime,
it is not specific to MainView objects.
The path has been changed to a constant of the implementation.
Reviewed by: Pierre Rossi
Reviewed by: Andrea Diamantini
| -rw-r--r-- | src/mainview.cpp | 8 | ||||
| -rw-r--r-- | src/mainview.h | 2 |
2 files changed, 4 insertions, 6 deletions
diff --git a/src/mainview.cpp b/src/mainview.cpp index e3e602b8..15d0edad 100644 --- a/src/mainview.cpp +++ b/src/mainview.cpp @@ -57,6 +57,9 @@ #include <QtGui/QToolButton> +// loading pixmap path +const QString loadingGifPath = KStandardDirs::locate("appdata" , "pics/loading.mng"); + MainView::MainView(MainWindow *parent) : KTabWidget(parent) , m_widgetBar(new StackedUrlBar(this)) @@ -71,9 +74,6 @@ MainView::MainView(MainWindow *parent) // set mouse tracking for tab previews setMouseTracking(true); - // loading pixmap path - m_loadingGitPath = KStandardDirs::locate("appdata" , "pics/loading.mng"); - // connecting tabbar signals connect(tabBar, SIGNAL(closeTab(int)), this, SLOT(closeTab(int))); connect(tabBar, SIGNAL(mouseMiddleClick(int)), this, SLOT(closeTab(int))); @@ -676,7 +676,7 @@ QLabel *MainView::animatedLoading(int index, bool addMovie) } if (addMovie && !label->movie()) { - QMovie *movie = new QMovie(m_loadingGitPath, QByteArray(), label); + QMovie *movie = new QMovie(loadingGifPath, QByteArray(), label); movie->setSpeed(50); label->setMovie(movie); movie->start(); diff --git a/src/mainview.h b/src/mainview.h index c59bd5e1..042b6371 100644 --- a/src/mainview.h +++ b/src/mainview.h @@ -179,8 +179,6 @@ private: StackedUrlBar *const m_widgetBar; - QString m_loadingGitPath; - // the new tab button QToolButton *const m_addTabButton; |