summaryrefslogtreecommitdiff
path: root/src/bookmarks
diff options
context:
space:
mode:
authoraqua <aqua@iserlohn-fortress.net>2022-09-22 22:07:28 +0300
committeraqua <aqua@iserlohn-fortress.net>2022-09-23 09:58:14 +0300
commit52c7c9c032d547b957808d07f53f58ed247f924c (patch)
treefcc510b06bfc1d5012689f2596758624f2b8db41 /src/bookmarks
parentBookmarksToolBar: elide action title (diff)
downloadrekonq-52c7c9c032d547b957808d07f53f58ed247f924c.tar.xz
Add validate_xml script
Diffstat (limited to 'src/bookmarks')
-rw-r--r--src/bookmarks/CMakeLists.txt5
-rw-r--r--src/bookmarks/bookmarkstreeitem.hpp4
2 files changed, 8 insertions, 1 deletions
diff --git a/src/bookmarks/CMakeLists.txt b/src/bookmarks/CMakeLists.txt
index 3f89c74f..0e9fef9e 100644
--- a/src/bookmarks/CMakeLists.txt
+++ b/src/bookmarks/CMakeLists.txt
@@ -16,4 +16,9 @@ if(${CMAKE_BUILD_TYPE} STREQUAL "Debug")
add_executable(xbel test/xbel.cpp)
target_link_libraries(xbel GTest::gtest GTest::gtest_main bookmarks)
gtest_discover_tests(xbel WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/test)
+
+ add_test(NAME bookmarks.validate_xml
+ COMMAND ${PROJECT_SOURCE_DIR}/scripts/validate_xml.py --dtd=${CMAKE_CURRENT_SOURCE_DIR}/test/xbel-1.0.dtd
+ ${CMAKE_CURRENT_SOURCE_DIR}/test/bookmarks.xbel
+ )
endif()
diff --git a/src/bookmarks/bookmarkstreeitem.hpp b/src/bookmarks/bookmarkstreeitem.hpp
index caed1ecb..91d4ab2a 100644
--- a/src/bookmarks/bookmarkstreeitem.hpp
+++ b/src/bookmarks/bookmarkstreeitem.hpp
@@ -40,7 +40,9 @@ public:
template <typename T> [[nodiscard]] QAction *action(T *sender, rekonq::OpenType type) const
{
- auto *action = new QAction(m_data.title, sender);
+ auto *action = new QAction(m_icon, m_data.title, sender);
+ action->setIconVisibleInMenu(true);
+ action->setToolTip(m_data.description.isEmpty() ? m_data.title : m_data.description);
QObject::connect(action, &QAction::triggered, sender,
[this, sender, type]() { emit sender->loadUrl(m_data.href, type); });
return action;