From 00332be135592f04c9c72829d7e3be39f8d79b63 Mon Sep 17 00:00:00 2001 From: Benjamin Poulain Date: Sat, 13 Nov 2010 16:24:12 +0100 Subject: Move download handling from WebView to WebPage Handling download is a responsibility of WebPage, the connection to the implementation is better done in WebPage than in WebView. Reviewed by: Pierre Rossi Reviewed by: Andrea Diamantini --- src/webpage.cpp | 1 + src/webview.cpp | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webpage.cpp b/src/webpage.cpp index 2347b6d8..4bbed2f5 100644 --- a/src/webpage.cpp +++ b/src/webpage.cpp @@ -210,6 +210,7 @@ WebPage::WebPage(QWidget *parent) // ----- last stuffs connect(manager, SIGNAL(finished(QNetworkReply*)), this, SLOT(manageNetworkErrors(QNetworkReply*))); + connect(this, SIGNAL(downloadRequested(const QNetworkRequest &)), this, SLOT(downloadRequest(const QNetworkRequest &))); connect(this, SIGNAL(loadStarted()), this, SLOT(loadStarted())); connect(this, SIGNAL(loadFinished(bool)), this, SLOT(loadFinished(bool))); diff --git a/src/webview.cpp b/src/webview.cpp index 14373db9..980060ef 100644 --- a/src/webview.cpp +++ b/src/webview.cpp @@ -94,7 +94,6 @@ WebView::WebView(QWidget* parent) // download system connect(this, SIGNAL(linkShiftClicked(const KUrl &)), page, SLOT(downloadUrl(const KUrl &))); - connect(page, SIGNAL(downloadRequested(const QNetworkRequest &)), page, SLOT(downloadRequest(const QNetworkRequest &))); // middle click || ctrl + click signal connect(this, SIGNAL(linkMiddleOrCtrlClicked(const KUrl &)), this, SLOT(loadUrlInNewTab(const KUrl &))); -- cgit v1.2.1