From 2c0e1fadc3d4bd997b2759879b939403e999ac78 Mon Sep 17 00:00:00 2001 From: Rohan Garg Date: Thu, 13 Jan 2011 00:49:59 +0530 Subject: Fix issues as pointed out by Krazy * Fix spelling issues * Wrap Strings in QL1S * Use Q_OBJECT macro in a class that derives from QObject --- src/bookmarks/bookmarkowner.h | 2 +- src/filterurljob.cpp | 2 +- src/opensearch/opensearchengine.h | 2 ++ src/opensearch/opensearchreader.cpp | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/bookmarks/bookmarkowner.h b/src/bookmarks/bookmarkowner.h index 4e3f0b11..5bfc6b80 100644 --- a/src/bookmarks/bookmarkowner.h +++ b/src/bookmarks/bookmarkowner.h @@ -72,7 +72,7 @@ public: // @{ /** - * Funtions to get current information. + * Functions to get current information. */ virtual QString currentTitle() const; virtual QString currentUrl() const; diff --git a/src/filterurljob.cpp b/src/filterurljob.cpp index c0632752..53b52b73 100644 --- a/src/filterurljob.cpp +++ b/src/filterurljob.cpp @@ -59,7 +59,7 @@ KUrl FilterUrlJob::url() void FilterUrlJob::run() { // Bookmarklets handling - if (_urlString.startsWith("javascript:")) + if (_urlString.startsWith(QL1S("javascript:"))) { _url = KUrl(_urlString); return; diff --git a/src/opensearch/opensearchengine.h b/src/opensearch/opensearchengine.h index a3ecf59f..c05501fb 100644 --- a/src/opensearch/opensearchengine.h +++ b/src/opensearch/opensearchengine.h @@ -48,6 +48,8 @@ class OpenSearchEngine : public QObject { + Q_OBJECT + public: typedef QPair Parameter; diff --git a/src/opensearch/opensearchreader.cpp b/src/opensearch/opensearchreader.cpp index aff9ff36..a111854c 100644 --- a/src/opensearch/opensearchreader.cpp +++ b/src/opensearch/opensearchreader.cpp @@ -153,7 +153,7 @@ OpenSearchEngine *OpenSearchReader::read() else { if (engine->suggestionsUrlTemplate().isEmpty() - && type == QL1S("application/x-suggestions+json")) //note: xml is prefered + && type == QL1S("application/x-suggestions+json")) //note: xml is preferred { engine->setSuggestionsUrlTemplate(url); engine->setSuggestionsParameters(parameters); -- cgit v1.2.1