From bd27f60d55315b2dad1aea17dbd6e27ff56feb9e Mon Sep 17 00:00:00 2001
From: Andrea Diamantini <adjam7@gmail.com>
Date: Sat, 14 Aug 2010 22:49:51 +0200
Subject: Follow pano & yoann suggestions about bookmark saving

---
 src/urlbar/urlbar.cpp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/urlbar/urlbar.cpp b/src/urlbar/urlbar.cpp
index 1928c0c5..e2033120 100644
--- a/src/urlbar/urlbar.cpp
+++ b/src/urlbar/urlbar.cpp
@@ -350,6 +350,9 @@ void UrlBar::loadFinished()
 
 void UrlBar::showBookmarkInfo(const QPoint &pos)
 {
+    if( _tab->url().scheme() == QL1S("about") )
+        return;
+    
     KBookmark bookmark = Application::bookmarkProvider()->bookmarkForUrl(_tab->url());
 
     IconButton *bt = qobject_cast<IconButton *>(this->sender());
@@ -358,14 +361,12 @@ void UrlBar::showBookmarkInfo(const QPoint &pos)
 
     if (bookmark.isNull())
     {
-        Application::bookmarkProvider()->rootGroup().addBookmark(_tab->view()->title(), _tab->url());
+        bookmark = Application::bookmarkProvider()->rootGroup().addBookmark(_tab->view()->title(), _tab->url());
         Application::bookmarkProvider()->bookmarkManager()->emitChanged();
     }
-    else
-    {
-        BookmarkWidget *widget = new BookmarkWidget(bookmark, window());
-        widget->showAt(pos);
-    }
+    
+    BookmarkWidget *widget = new BookmarkWidget(bookmark, window());
+    widget->showAt(pos);
 }
 
 
-- 
cgit v1.2.1