From f2c6ceb47a15e2a9de99ae9a0ed4d955d0356528 Mon Sep 17 00:00:00 2001
From: aqua <aqua@iserlohn-fortress.net>
Date: Sun, 18 Sep 2022 18:15:52 +0300
Subject: Fix compiler warnings

---
 src/bookmarks/bookmarkstreeitem.hpp | 2 +-
 src/plugins/pluginloader.cpp        | 3 ++-
 src/taskmanager.cpp                 | 2 +-
 src/urlbar/completer.cpp            | 2 --
 src/urlbar/completer.hpp            | 1 +
 src/urlbar/urlbar.cpp               | 2 +-
 src/urlbar/urlbar.hpp               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/bookmarks/bookmarkstreeitem.hpp b/src/bookmarks/bookmarkstreeitem.hpp
index 05a71ce2..caed1ecb 100644
--- a/src/bookmarks/bookmarkstreeitem.hpp
+++ b/src/bookmarks/bookmarkstreeitem.hpp
@@ -44,7 +44,7 @@ public:
     QObject::connect(action, &QAction::triggered, sender,
                      [this, sender, type]() { emit sender->loadUrl(m_data.href, type); });
     return action;
-  };
+  }
 
   [[nodiscard]] BookmarksTreeItem *parent() const { return m_parent; }
 
diff --git a/src/plugins/pluginloader.cpp b/src/plugins/pluginloader.cpp
index ad5dbc14..fc793647 100644
--- a/src/plugins/pluginloader.cpp
+++ b/src/plugins/pluginloader.cpp
@@ -13,5 +13,6 @@
 PluginLoader::PluginLoader(const QString &fileName, QObject *parent) : QPluginLoader(fileName, parent)
 {
   const auto metadata = metaData()["MetaData"].toObject();
-  for (const auto &value : metadata["schemes"].toArray()) { m_schemes.append(value.toString()); }
+  const auto schemes = metadata["schemes"].toArray();
+  for (const auto &value : schemes) { m_schemes.append(value.toString()); }
 }
diff --git a/src/taskmanager.cpp b/src/taskmanager.cpp
index 6f90bf89..75a168ce 100644
--- a/src/taskmanager.cpp
+++ b/src/taskmanager.cpp
@@ -28,7 +28,7 @@ TaskManager::TaskManager(QWidget *parent) : QDialog(parent), ui(new Ui::TaskMana
     item->setData(Qt::UserRole, QVariant::fromValue(plugin));
   }
   connect(ui->plugins, &QListWidget::itemClicked, this, &TaskManager::showPluginDetails);
-  connect(ui->pluginState, &QPushButton::clicked, [this](bool checked) {
+  connect(ui->pluginState, &QPushButton::clicked, this, [this](bool checked) {
     auto *item = ui->plugins->currentItem();
     auto plugin = item->data(Qt::UserRole).value<QPointer<PluginLoader>>();
     Q_CHECK_PTR(plugin);
diff --git a/src/urlbar/completer.cpp b/src/urlbar/completer.cpp
index df864e05..a7b893df 100644
--- a/src/urlbar/completer.cpp
+++ b/src/urlbar/completer.cpp
@@ -14,8 +14,6 @@
 #include <QLineEdit>
 #include <QTreeWidget>
 
-static const QString searchUrl{"https://duckduckgo.com/?q=%1"};
-
 // ------------------------------------------------------------------------
 // Ctor and Dtor
 
diff --git a/src/urlbar/completer.hpp b/src/urlbar/completer.hpp
index 11c0f62b..fad22df2 100644
--- a/src/urlbar/completer.hpp
+++ b/src/urlbar/completer.hpp
@@ -30,4 +30,5 @@ public slots:
 private:
   QLineEdit *m_editor;
   QTreeWidget *m_popup;
+  const QString searchUrl{"https://duckduckgo.com/?q=%1"};
 };
diff --git a/src/urlbar/urlbar.cpp b/src/urlbar/urlbar.cpp
index 6c726d5a..4489765c 100644
--- a/src/urlbar/urlbar.cpp
+++ b/src/urlbar/urlbar.cpp
@@ -105,7 +105,7 @@ void UrlBar::setUrl(const QUrl &url)
   setCursorPosition(0);
 }
 
-void UrlBar::loadRequestedUrl(const QUrl &url, rekonq::OpenType type)
+void UrlBar::loadRequestedUrl(const QUrl &url, rekonq::OpenType)
 {
   clearFocus();
   setText(url.toString());
diff --git a/src/urlbar/urlbar.hpp b/src/urlbar/urlbar.hpp
index 3e3b9059..7b6cc975 100644
--- a/src/urlbar/urlbar.hpp
+++ b/src/urlbar/urlbar.hpp
@@ -57,7 +57,7 @@ public slots:
    */
   // void manageBookmarks();
 
-  void loadRequestedUrl(const QUrl &url, rekonq::OpenType = rekonq::CurrentTab);
+  [[deprecated]] void loadRequestedUrl(const QUrl &url, rekonq::OpenType = rekonq::CurrentTab);
 
   void loadStarted();
   void loadProgress(int);
-- 
cgit v1.2.1