From fe02d0962810b1ebca33c219274a5e3390de5286 Mon Sep 17 00:00:00 2001 From: Benjamin Poulain Date: Sun, 22 Aug 2010 01:17:43 +0200 Subject: Make the FindBar a bit more robust The FindBar was slots show() and hide() instead of the virtual method QWidget::setVisible(). This can lead to subtle bugs, because the behavior is different depending on the type of call (signal-slot connection VS direct call on a pointer to QWidget) and the function called (hide() is != than setVisible(false)). --- src/findbar.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/findbar.h') diff --git a/src/findbar.h b/src/findbar.h index 38bbcbc5..974d6137 100644 --- a/src/findbar.h +++ b/src/findbar.h @@ -55,9 +55,9 @@ public: void notifyMatch(bool match); bool highlightAllState() const; + void setVisible(bool visible); + public slots: - void show(); - void hide(); void toggleVisibility(); signals: -- cgit v1.2.1