From facc2f92fe73d4e925510fcb2936483798efba6a Mon Sep 17 00:00:00 2001
From: Andrea Diamantini <adjam7@gmail.com>
Date: Wed, 23 Jan 2013 19:04:05 +0100
Subject: Improve icon management code

In the 1.x way, IconManager notified all the tabs about icons changed.
This way, just the interested tab is :)
---
 src/icons/iconmanager.cpp | 14 +-------------
 src/icons/iconmanager.h   |  3 ---
 2 files changed, 1 insertion(+), 16 deletions(-)

(limited to 'src/icons')

diff --git a/src/icons/iconmanager.cpp b/src/icons/iconmanager.cpp
index 49d637ad..e0408577 100644
--- a/src/icons/iconmanager.cpp
+++ b/src/icons/iconmanager.cpp
@@ -115,27 +115,15 @@ void IconManager::provideIcon(QWebFrame *mFrame, const KUrl &url, bool notify)
 {
     // provide icons just for http/https sites
     if (!url.scheme().startsWith(QL1S("http")))
-    {
-        if (notify)
-            emit iconChanged();
         return;
-    }
 
     // do not load new icons in private browsing..
     if (mFrame->page()->settings()->testAttribute(QWebSettings::PrivateBrowsingEnabled))
-    {
-        if (notify)
-            emit iconChanged();
         return;
-    }
 
     // check if icon exists
     if (!favIconForUrl(url).isEmpty())
-    {
-        if (notify)
-            emit iconChanged();
         return;
-    }
 
     // the simplest way..
     const QString rootUrlString = url.scheme() + QL1S("://") + url.host();
@@ -165,7 +153,7 @@ void IconManager::provideIcon(QWebFrame *mFrame, const KUrl &url, bool notify)
 
     IconDownloader *id = new IconDownloader(faviconUrl, destUrl, this);
     if (notify)
-        connect(id, SIGNAL(iconReady()), this, SIGNAL(iconChanged()));
+        connect(id, SIGNAL(iconReady()), mFrame, SIGNAL(iconChanged()));
 }
 
 
diff --git a/src/icons/iconmanager.h b/src/icons/iconmanager.h
index 02ae6763..9f39f965 100644
--- a/src/icons/iconmanager.h
+++ b/src/icons/iconmanager.h
@@ -64,9 +64,6 @@ public:
 
     void saveDesktopIconForUrl(const KUrl &u);
 
-Q_SIGNALS:
-    void iconChanged();
-
 private:
     IconManager(QObject *parent = 0);
 
-- 
cgit v1.2.1