From 9b0dc8d98fb232cabb683d5681dc0252b9532c32 Mon Sep 17 00:00:00 2001 From: Andrea Diamantini Date: Thu, 19 Jan 2012 09:32:07 +0100 Subject: Krazy fixes - QL1S/QL1C - single-char QString efficiency - explicit ctors - normalized signals & slots --- src/tests/mainview_test.cpp | 52 ++++++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 26 deletions(-) (limited to 'src/tests') diff --git a/src/tests/mainview_test.cpp b/src/tests/mainview_test.cpp index 141490ea..8426dba1 100644 --- a/src/tests/mainview_test.cpp +++ b/src/tests/mainview_test.cpp @@ -128,8 +128,8 @@ void MainViewTest::closeTab() { // QFETCH(int, index); // -// QSignalSpy spy1(view, SIGNAL(linkHovered(const QString &))); -// QSignalSpy spy2(view, SIGNAL(setCurrentTitle(const QString &))); +// QSignalSpy spy1(view, SIGNAL(linkHovered(QString))); +// QSignalSpy spy2(view, SIGNAL(setCurrentTitle(QString))); // QSignalSpy spy3(view, SIGNAL(tabsChanged())); // QSignalSpy spy4(view, SIGNAL(lastTabClosed())); // @@ -162,10 +162,10 @@ void MainViewTest::currentWebView() SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -194,9 +194,9 @@ void MainViewTest::newTab() { // QFETCH(int, foo); // -// QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); -// QSignalSpy spy1(view, SIGNAL(setCurrentTitle(const QString &))); -// QSignalSpy spy2(view, SIGNAL(showStatusBarMessage(const QString &))); +// QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); +// QSignalSpy spy1(view, SIGNAL(setCurrentTitle(QString))); +// QSignalSpy spy2(view, SIGNAL(showStatusBarMessage(QString))); // QSignalSpy spy3(view, SIGNAL(tabsChanged())); // QSignalSpy spy4(view, SIGNAL(lastTabClosed())); // @@ -225,10 +225,10 @@ void MainViewTest::nextTab() SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -261,10 +261,10 @@ void MainViewTest::previousTab() SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -291,10 +291,10 @@ void MainViewTest::recentlyClosedTabs() /* SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -324,10 +324,10 @@ void MainViewTest::setCurrentTitle(const QString &) SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -359,10 +359,10 @@ void MainViewTest::showStatusBarMessage(const QString &) SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); @@ -393,10 +393,10 @@ void MainViewTest::currentChanged() SubMainView widget; - QSignalSpy spy0(view, SIGNAL(linkHovered(const QString &))); + QSignalSpy spy0(view, SIGNAL(linkHovered(QString))); QSignalSpy spy2(view, SIGNAL(loadProgress(int))); - QSignalSpy spy3(view, SIGNAL(setCurrentTitle(const QString &))); - QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(const QString &))); + QSignalSpy spy3(view, SIGNAL(setCurrentTitle(QString))); + QSignalSpy spy4(view, SIGNAL(showStatusBarMessage(QString))); QSignalSpy spy5(view, SIGNAL(tabsChanged())); QSignalSpy spy6(view, SIGNAL(lastTabClosed())); -- cgit v1.2.1