From a3e2208ae3b2190b3f176a7cf52d65bb4d42d82d Mon Sep 17 00:00:00 2001 From: Andrea Diamantini Date: Mon, 14 Jan 2013 22:21:53 +0100 Subject: Coverity report fixes A potential crash (dynamic_cast maybe null) Some break usage clean up minor string speed up by using QLatin1String --- src/urlbar/bookmarkwidget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/urlbar') diff --git a/src/urlbar/bookmarkwidget.cpp b/src/urlbar/bookmarkwidget.cpp index e266a071..fc3139d0 100644 --- a/src/urlbar/bookmarkwidget.cpp +++ b/src/urlbar/bookmarkwidget.cpp @@ -64,6 +64,8 @@ BookmarkWidget::BookmarkWidget(const KBookmark &bookmark, QWidget *parent) : QMenu(parent) , m_bookmark(new KBookmark(bookmark)) + , m_tagLine(new KLineEdit(this)) + , m_commentEdit(new QPlainTextEdit(this)) { setAttribute(Qt::WA_DeleteOnClose); setFixedWidth(320); @@ -137,7 +139,6 @@ BookmarkWidget::BookmarkWidget(const KBookmark &bookmark, QWidget *parent) QLabel *commentLabel = new QLabel(this); commentLabel->setText(i18n("Describe:")); commentLabel->setAlignment(Qt::AlignCenter); - m_commentEdit = new QPlainTextEdit(this); if (!m_nfoResource.description().isEmpty()) { m_commentEdit->setPlainText(m_nfoResource.description()); @@ -149,7 +150,6 @@ BookmarkWidget::BookmarkWidget(const KBookmark &bookmark, QWidget *parent) QLabel *tagLabel = new QLabel(this); tagLabel->setText(i18n("Tags:")); tagLabel->setAlignment(Qt::AlignLeft); - m_tagLine = new KLineEdit(this); m_tagLine->setPlaceholderText(i18n("add tags(comma separated)")); -- cgit v1.2.1