From ad8ab01c115d3e1ec22ce649a54ab28609624b61 Mon Sep 17 00:00:00 2001 From: Andrea Diamantini Date: Fri, 25 Feb 2011 00:44:56 +0100 Subject: cppcheck round... --- src/analyzer/networkanalyzer.cpp | 2 ++ src/application.cpp | 1 - src/bookmarks/bookmarkprovider.cpp | 2 ++ src/findbar.cpp | 4 ---- src/history/historymanager.h | 4 +++- src/opensearch/opensearchengine.cpp | 2 +- src/opensearch/opensearchengine.h | 5 ++--- src/webview.h | 4 ++-- 8 files changed, 12 insertions(+), 12 deletions(-) (limited to 'src') diff --git a/src/analyzer/networkanalyzer.cpp b/src/analyzer/networkanalyzer.cpp index a3675dfa..3101dae5 100644 --- a/src/analyzer/networkanalyzer.cpp +++ b/src/analyzer/networkanalyzer.cpp @@ -45,6 +45,7 @@ #include #include + NetworkAnalyzer::NetworkAnalyzer(QWidget *parent) : QWidget(parent) , _mapper(new QSignalMapper(this)) @@ -76,6 +77,7 @@ NetworkAnalyzer::~NetworkAnalyzer() { } + void NetworkAnalyzer::popupContextMenu(const QPoint& pos) { if (_requestList->topLevelItemCount() >= 1) diff --git a/src/application.cpp b/src/application.cpp index 66d1384e..97d9a571 100644 --- a/src/application.cpp +++ b/src/application.cpp @@ -271,7 +271,6 @@ HistoryManager *Application::historyManager() if (m_historyManager.isNull()) { m_historyManager = new HistoryManager(instance()); - QWebHistoryInterface::setDefaultInterface(m_historyManager.data()); } return m_historyManager.data(); } diff --git a/src/bookmarks/bookmarkprovider.cpp b/src/bookmarks/bookmarkprovider.cpp index 6d7a6440..1bcff5eb 100644 --- a/src/bookmarks/bookmarkprovider.cpp +++ b/src/bookmarks/bookmarkprovider.cpp @@ -102,6 +102,8 @@ BookmarkProvider::~BookmarkProvider() KActionMenu* BookmarkProvider::bookmarkActionMenu(QWidget *parent) { + kDebug() << "creating a bookmarks action menu..."; + KMenu *menu = new KMenu(parent); KActionMenu *bookmarkActionMenu = new KActionMenu(menu); bookmarkActionMenu->setMenu(menu); diff --git a/src/findbar.cpp b/src/findbar.cpp index c1f170cd..aefdffe1 100644 --- a/src/findbar.cpp +++ b/src/findbar.cpp @@ -118,10 +118,6 @@ FindBar::FindBar(MainWindow *window) FindBar::~FindBar() { - delete m_lineEdit; - delete m_hideTimer; - delete m_matchCase; - delete m_highlightAll; } diff --git a/src/history/historymanager.h b/src/history/historymanager.h index a7a7661e..eb8d78d7 100644 --- a/src/history/historymanager.h +++ b/src/history/historymanager.h @@ -56,7 +56,9 @@ class HistoryItem { public: - HistoryItem() {} + HistoryItem() + {} + explicit HistoryItem(const QString &u, const QDateTime &d = QDateTime(), const QString &t = QString() diff --git a/src/opensearch/opensearchengine.cpp b/src/opensearch/opensearchengine.cpp index dcd0f8b4..cfd9b4b6 100644 --- a/src/opensearch/opensearchengine.cpp +++ b/src/opensearch/opensearchengine.cpp @@ -30,7 +30,7 @@ // Self Includes #include "opensearchengine.h" -#include "suggestionparser.h" +#include "opensearchengine.moc" // Qt Includes #include diff --git a/src/opensearch/opensearchengine.h b/src/opensearch/opensearchengine.h index 8194cfb2..cc826aec 100644 --- a/src/opensearch/opensearchengine.h +++ b/src/opensearch/opensearchengine.h @@ -33,6 +33,8 @@ // Rekonq Includes #include "rekonq_defines.h" + +// Local Includes #include "suggestionparser.h" // KDE Includes @@ -43,9 +45,6 @@ #include -// Forward Declarations - - class OpenSearchEngine : public QObject { Q_OBJECT diff --git a/src/webview.h b/src/webview.h index 7f981abb..b954c17e 100644 --- a/src/webview.h +++ b/src/webview.h @@ -66,7 +66,7 @@ protected: void wheelEvent(QWheelEvent *event); void dropEvent(QDropEvent *event); -private slots: +private Q_SLOTS: void search(); void printFrame(); @@ -87,7 +87,7 @@ private slots: void stopScrolling(); void changeWindowIcon(); -signals: +Q_SIGNALS: void loadUrl(const KUrl &, const Rekonq::OpenType &); void zoomChanged(int); void openPreviousInHistory(); -- cgit v1.2.1