From b0d83c63ef169f18ecdb5d28575ad7f76c3881fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20Ander=20Pe=C3=B1alba?= Date: Tue, 19 Oct 2010 20:40:09 +0200 Subject: Minor clean-up to the UrlPanel class --- src/urlfilterproxymodel.h | 5 ++--- src/urlpanel.cpp | 5 ----- src/urlpanel.h | 24 ++++++++++++------------ 3 files changed, 14 insertions(+), 20 deletions(-) (limited to 'src') diff --git a/src/urlfilterproxymodel.h b/src/urlfilterproxymodel.h index 06592c27..a456a21e 100644 --- a/src/urlfilterproxymodel.h +++ b/src/urlfilterproxymodel.h @@ -39,16 +39,15 @@ /** * QSortFilterProxyModel hides all children which parent doesn't * match the filter. This class is used to change this behavior. - * If a url matches the filter it'll be shown, + * If a url matches the filter it'll be shown, * even if it's parent doesn't match it. - * */ class REKONQ_TESTS_EXPORT UrlFilterProxyModel : public QSortFilterProxyModel { Q_OBJECT public: - UrlFilterProxyModel(QObject *parent = 0); + explicit UrlFilterProxyModel(QObject *parent = 0); protected: virtual bool filterAcceptsRow(const int source_row, const QModelIndex &source_parent) const; diff --git a/src/urlpanel.cpp b/src/urlpanel.cpp index 8753038c..b3e8b2f3 100644 --- a/src/urlpanel.cpp +++ b/src/urlpanel.cpp @@ -54,11 +54,6 @@ UrlPanel::UrlPanel(const QString &title, QWidget *parent, Qt::WindowFlags flags) } -UrlPanel::~UrlPanel() -{ -} - - void UrlPanel::showing(bool b) { if(!_loaded && b) diff --git a/src/urlpanel.h b/src/urlpanel.h index 2bf1c3fe..722eeae0 100644 --- a/src/urlpanel.h +++ b/src/urlpanel.h @@ -33,7 +33,7 @@ #include "rekonq_defines.h" // Qt Includes -#include +#include // Forward Declarations class PanelTreeView; @@ -47,25 +47,25 @@ class REKONQ_TESTS_EXPORT UrlPanel : public QDockWidget public: explicit UrlPanel(const QString &title, QWidget *parent = 0, Qt::WindowFlags flags = 0); - virtual ~UrlPanel(); + virtual ~UrlPanel() {} + +Q_SIGNALS: + void openUrl(const KUrl &, const Rekonq::OpenType &); + void itemHovered(const QString &); - inline PanelTreeView *panelTreeView() const { return _treeView; }; - public Q_SLOTS: void showing(bool); -protected Q_SLOTS: - virtual void contextMenuItem(const QPoint &pos) = 0; - virtual void contextMenuGroup(const QPoint &pos) = 0; - virtual void contextMenuEmpty(const QPoint &pos) = 0; - protected: virtual void setup(); virtual QAbstractItemModel* getModel() = 0; -Q_SIGNALS: - void openUrl(const KUrl &, const Rekonq::OpenType &); - void itemHovered(const QString &); + PanelTreeView* panelTreeView() const {return _treeView;} + +protected Q_SLOTS: + virtual void contextMenuItem(const QPoint &pos) = 0; + virtual void contextMenuGroup(const QPoint &pos) = 0; + virtual void contextMenuEmpty(const QPoint &pos) = 0; private: PanelTreeView *_treeView; -- cgit v1.2.1